use the new manage access dialog - #762
Open
SharonStrats wants to merge 2 commits into
Open
SharonStrats wants to merge 2 commits into
SharonStrats wants to merge 2 commits into
Conversation
…@5.0.0-2 pane-registry@5.0.0-1 activitystreams-pane@2.0.0-0 chat-pane@4.0.0-0 contacts-pane@4.0.0-0 folder-pane@4.0.0-0 issue-pane@4.0.0-0 meeting-pane@4.0.0-0 profile-pane@4.0.0-0 source-pane@4.0.0-0) (latest: rdflib@2.4.1)
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The pinned solid-ui version lacks the imported modal package, preventing manager.js from loading.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Replaces the legacy sharing pane with the new Manage Access dialog.
Changes:
- Fetches access grants through
solid-logic. - Opens
AccessControlModalwith the resource URI and grants.
| File | Summary | Review |
|---|---|---|
src/outline/manager.js |
Integrates the Manage Access dialog. | Critical: update solid-ui dependency metadata and lockfile to a release containing the access-control modal. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| import { loadContainerRepresentation } from '../utils/podUtils' | ||
| import { isWebIdUri } from '../utils/webIdUtils' | ||
| import '../components/file-explorer-header' | ||
| import AccessControlModal from 'solid-ui/components/access-control-modal' |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also needs new solid-logic and solid-ui.