Repository navigation
Conversation
chrishalcrow
commented
Oct 15, 2026
for more information, see https://pre-commit.ci
Member
|
@chrishalcrow can you add a descriptions and fix tests here? :) |
chrishalcrow
marked this pull request as ready for review
October 27, 2026 09:53
alejoe91
approved these changes
Oct 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sorting has
main_channel_ids, while an analyzer hasmain_channel_indices.To do go from ids to indices the analyzer must, on creation or load, have access to the channel ids to indices map. On load, we were getting this from the recording attached to the analyzer. But often the recording becomes unattached to the analyzer. There is a more robust way to get this map: through the
rec_attributesof the analyzer. This PR allows the analyzer to userec_attributes!