Repository navigation
avoid sharing title casing state between generators - #14
Merged
Merged
Conversation
The package-level title caser shares mutable state even when each goroutine owns a separate Generator, causing data races and panics. Create a fresh caser for each title conversion to preserve the existing Unicode casing behavior without sharing state.
Owner
|
Brilliant. Thank you for the contribution, @crazy-max |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating title-cased names concurrently can race and panic even when each goroutine owns a separate
Generator, as the documentation recommends. All generators currently share a package-levelcases.Caser, whose mutable state is modified during conversion. Create a fresh caser for each title conversion to eliminate the shared state while preserving existing Unicode casing behavior.Before the fix, this produced data-race reports followed by the following panic. Note that the panic and its exact message depend on goroutine scheduling.
The panic originated in
golang.org/x/text/transform.String, called throughcases.Caser.StringandGenerator.applyCasing.