Repository navigation
ReviewSLA: check every recently pushed repo rather than an explicit list - #55
Open
willson556 wants to merge 1 commit into
Open
willson556 wants to merge 1 commit into
willson556 wants to merge 1 commit into
Conversation
… team With no `repos` input, the job now lists the org's repos pushed to within `active-days` (default 30), leaving out archived ones, instead of needing each repo added to the workflow by hand. A `repos` list still wins. That reaches other teams' repos, so only assignees on the rotation team (embeddedreviewers) get clocks: other teams' PRs get no comments, reminders or reassignment, and stay off the dashboard. If the repos or the team can't be read, the run changes nothing, rather than showing everyone as clear. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
willson556
marked this pull request as ready for review
November 10, 2026 21:43
staflsystemsci
Bot
requested review from
fcheein,
gretl-silva-stafl,
mament0,
mns4595,
mzhu48,
nehalkpatel and
thebhef
November 10, 2026 21:44
|
Review SLA
Due times are in business hours, 10:00 to 17:00 Pacific: 4 h for a PR under 250 added lines, 7 h otherwise, and 4 h for a re-review. Mid-stack, an assignee owes a response on the lowest PR they haven't approved. Dashboard |
willson556
changed the title
gretl-silva-stafl
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops the Review SLA job needing each repo added to its workflow by hand. With no
reposinput, each run now lists the org's repos pushed to in the last 30 days (active-days), leaving out archived ones, and checks those. Any push counts, including to a PR's branch. Areposlist, if given, still wins.That widens the job to other teams' repos. Pushed in the last 30 days is currently 28 repos, against the 7 listed today, including StaflHub, stafl-customer-portal and manufacturing-results-backend. So the job now tracks only assignees on the rotation team (
embeddedreviewers). Other teams' PRs get no Review SLA comment, reminder or out-of-office reassignment, and don't appear on the dashboard. An embedded engineer assigned in any repo is still covered.It fails safe: if the repo list or the team can't be read, the run warns and changes nothing. Carrying on with no repos would update the dashboard to show everyone as clear.
With an app installation token, the list covers the private repos the staflsystemsci app is installed on and every public repo. A new private repo is picked up once the app is installed on it.
After this merges, review-automation's workflow drops its
repos:list (I'll commit that to its main). Until then its list keeps the job on today's 7 repos.Testing:
node --test AssignReviewers/ ReviewConfig/ ReviewSLA/: 104 cases, 4 of them new:active-daysnarrows the window;🤖 Generated with Claude Code