[dmccoystephenson]

Summary

Four player-facing statements were found to be untrue or misleading in ordinary states, all in files already at 100% line coverage.

• Ledger (Selling the last rental unit erases the rental record from the ledger #252): the investment block was gated on owning a unit today, so selling the last one erased Lifetime Rental Income from See Stats and from the retirement summary. It is now gated on rentalProperties or totalPropertiesBought, matching the fleet and business blocks beside it. Both fields arrived in Add Home Ownership (trade-up) and Investment Properties #104, so no legacy save is affected.
• Shop (Shop reports "Sold fish for $0.00" when it could not buy anything #253): a sale to a shop with no budget left reported Sold fish for $0.00. The sale clause is now dropped when nothing was sold.
• Old Tom (Crew dialogue misreads a first hire: Old Tom's plurals for one hand, Margaret's $0 in wages #254): one hire was described in the plural (Asha hold court ... not one of them's had a bad word). Singular wording was added to both the paid and the unpaid branch, as Shop._crewCustomerDialogue already does.
• Margaret (Crew dialogue misreads a first hire: Old Tom's plurals for one hand, Margaret's $0 in wages #254): $0 in wages was praised before the first payday, at both tier stages. A zero-wages line now comes first, and it says wages leave the purse rather than the account, matching boats.runDailyProduction.

An existing assertion was changed: test_old_tom_crew_question_is_locked_until_someone_is_hired hires one villager and had pinned the plural bug. The plural wording stays covered by a new test with two hires.

Left unchanged, as noted on #253: sellFish stops at the first unaffordable fish, so cheaper fish can stay unsold while a few dollars remain in the budget.

No open issues were skipped: the backlog was empty at triage, so these were found by a fresh scan. No schemas/, reader/writer, save-manager or workflow path is touched, and option order is unchanged.

Test plan

• python3 -m compileall -q src
• Full suite under dummy SDL drivers: 1087 passed (1081 on main)
• New regression tests stashed against the unfixed source: 6 cases failed, then passed with the fixes restored
• Each symptom reproduced first on real Home, Shop, Tavern and Bank instances
• CI green on the PR head

Closes #252
Closes #253
Closes #254

This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).

🤖 Generated with Claude Code

---

drafted by Claude on behalf of Daniel Stephenson

[dmccoystephenson]

Self-review rubric, scored on 801dbf3 against CI run 41981452273 (test and docker green, 1087 passed). One FAIL was fixed in the follow-up commit, which changes a comment only.

• Scope: PASS — four src/location files and their test mirrors, each tied to Selling the last rental unit erases the rental record from the ledger #252, Shop reports "Sold fish for $0.00" when it could not buy anything #253 or Crew dialogue misreads a first hire: Old Tom's plurals for one hand, Margaret's $0 in wages #254.
• Tests-new: PASS — no new public method was added; each changed branch has a test.
• Tests-fix: PASS — with the src changes stashed, 6 cases failed (home 1, shop 1, bank 2, tavern 2), and all passed once restored. The plural tavern tests pass both ways by design, as guards on existing behaviour.
• Sibling structure: PASS — tests follow the # prepare / # call / # check layout, and no new file was added.
• Sibling renames: PASS — nothing was renamed.
• Docs: PASS — no README edit is needed. README.md:162 already promises that the property part of the ledger appears once earned and that "a total you've built up stays on the ledger even after you've sold what earned it", so Selling the last rental unit erases the rental record from the ledger #252 brings the code back in line with the README. No schema or PLANNING claim covers these strings.
• Issue resolution: PASS — all three named surfaces were changed, in both Old Tom branches and at both Margaret tier stages.
• CI: PASS — green on 801dbf3; to be re-confirmed on the final head before merge.
• Schema-sync: PASS — no persisted field changed.
• Money-format: PASS — no money display was added; $%.2f remains in the changed Old Tom string.
• Deterministic-tests: PASS — the new shop test sets the budget to 0, so no random sale price affects it.
• Headless-pygame: PASS — no pygame path was touched.
• camelCase: PASS — onlyOne.
• Comment accuracy: FAIL, fixed — the src/location/bank.py comment assumed a pronoun for an NPC and claimed "the one time", which was not established. It was reworded.

Notes:

• src/location/shop.py — black --check still fails on this file, but only on existing dialogue hunks outside this diff. They were left out of scope.
• src/location/docks.py:299 — Sam's I've known every one of 'em has the same one-hand problem as Old Tom's line. It is outside the surface named by Crew dialogue misreads a first hire: Old Tom's plurals for one hand, Margaret's $0 in wages #254, so it is tracked separately rather than added here.
• tests/location/test_tavern.py:604 — an existing assertion was deliberately changed because it pinned the plural bug; the plural wording stays covered by the new two-hire test.

This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). It is a self-review and not an independent one.

---

drafted by Claude on behalf of Daniel Stephenson