Repository navigation
Document silent drops and where the log callback runs - #29
Merged
dmccoystephenson merged 1 commit intoNov 5, 2026
Merged
Conversation
Stage A documentation sweep. The README and the Report and constructor XML docs did not say that a NaN or infinite value is left out, that a null or blank name sends and logs nothing, or which thread the log callback runs on and what its messages contain. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (plain comment; not an independent review):
Findings noted, not changed:
Do-not-auto-merge check: neither path is listed, and the Local anchor: UNVERIFIED (no .NET SDK in the dispatch sandbox), so CI on the exact head SHA was used as the gate. This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
dmccoystephenson
deleted the
feature/document-silent-drops-and-log-thread
branch
November 5, 2026 03:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage A documentation accuracy sweep. Only docs change: the edits are to
README.mdand to XML doc comments inTraceClient.cs, and no executable line is touched. Everything added describes what the code already does.valueis omitted "when not given".Jsonalso omits a NaN or infinite value and still sends the event. The README and theReportXML doc now say so.Reportreturns before anything else for these, with no log line. The README says "Drops go to the optionallogcallback", so this case is now stated in the README and theReportXML doc.logcallback. Its thread was undocumented, which matters for Unity, where a callback can arrive off the main thread. The README and the constructor'slogparameter doc now cover which thread each message arrives on, the need for a quick and thread-safe callback, and that a failed delivery's message includes the JSON body. A note says the client does not write the key into any message.The first two match trace-client-python's Stephenson-Software/trace-client-python#24.
No tracking issue: the gaps were found during triage.
Test plan
Buildworkflow green on ubuntu-latest (net8.0): 102 tests, run 41959743507Buildworkflow green on windows-latest (net8.0 + net48): 102 tests on each; doc comments are compiled, and warnings are errorsThe local anchor is UNVERIFIED: no .NET SDK is installed in the dispatch sandbox, so the CI matrix on the head SHA is the gate. No new tests were needed. The behaviour described is covered by
Json_EscapesControlCharactersAndSkipsNullOrBlankTags,Json_OmitsAnInfiniteValueLikeNaNandReport_IgnoresABlankName, although the last of these does not assert that nothing is logged.Deferred
User-Agent) was not picked. It changes the wire-format contract shared with the Java and Python clients, so a maintainer has to decide it. The new coalescing parity issue, Repeated events are not coalesced, unlike trace-client-java 0.7.0 #28, is deferred for the same reason.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson