Repository navigation
Bring the docs up to date with coalescing - #32
Merged
Merged
Conversation
The class Javadoc still said three properties hold for report() after 0.7.0 added a fourth; the logger Javadoc said only a full queue drops silently, but so does a new event past MAX_COALESCED_EVENTS; the wire format did not mention the coalesced tag; and the counting formula did not say that a count at MAX_TAGS, or on an event with its own coalesced tag, is sent untagged (#31). Also rejoins a line break in close(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (scored after CI went green on all three legs,
Findings:
Summary: the PR touches documentation only and contains no do-not-auto-merge paths (no pom.xml, workflow, contract constant, version, or "Opting out"/"Keys" section changes). This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage A documentation accuracy sweep, run after the 0.7.0 coalescing change (#30). Each claim was checked against
TraceClient.java.Summary
report" is corrected to "Four". The list gained "It is throttled" in 0.7.0, but the count was not updated.Builder.loggerJavadoc: said only a report dropped by a full queue goes unlogged. A new event dropped becauseMAX_COALESCED_EVENTSother events are already being counted is also unlogged (report():return; // bounded, like a full queue: dropped without a log line). That case is now stated.report(String, Double, Map)Javadoc and README "Repeated events are coalesced": the counting formula ("sum ofvaluewherecoalescedis present, 1 where not") is now qualified.withCountdoes not add the tag when the event already hasMAX_TAGStags or its owncoalescedtag, so such a count reads as a single report. Only the current behaviour is documented here. Whether to change it is a wire-format decision, filed as A coalesced count at MAX_TAGS, or on an event with its own coalesced tag, is sent without its count tag #31.coalesced.close()Javadoc: a stray line break is rejoined, with no wording change.No code, contract strings, version strings, or "Opting out"/"Keys" README sections are touched.
Open issues not picked
Test plan
mvn -B verifylocally on Java 21: 94 tests run, 0 failuresNo tracking issue: the drift was found during the sweep. Follow-up filed: #31.
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
drafted by Claude on behalf of Daniel Stephenson
🤖 Generated with Claude Code