Skip to content

Match default vehicle upkeep to Main - #197

Open
Drefvelin wants to merge 2 commits into
mainfrom
chore/sync-upkeep-with-main
Open

Drefvelin wants to merge 2 commits into
mainfrom
chore/sync-upkeep-with-main

Conversation

@Drefvelin

@Drefvelin Drefvelin commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

The bundled vehicles.yml still carries the original upkeep numbers, while Main's were lowered on the server. This copies Main's vehicle values into the defaults, for example cruiser 40 → 12, behemoth 50 → 20, fixed artillery 12 → 2 and field artillery 4 → 1. It also adds flat_car and passenger_car_open, which Main already lists.

Hold until confirmed: it isn't confirmed yet whether Main's lower vehicle upkeep is intended. If it isn't, close this and fix Main instead.

Installation upkeep is not changed. The repo's 30/15/20 is the intended rebalance from #105; Main still had the values from before it, and Main's file has now been corrected to 30/15/20.

maintenance-interval-ticks stays. Config only; the tests write their own vehicles.yml.

🤖 Generated with Claude Code

Main's installations.yml and vehicles.yml were tuned on the server and
the bundled defaults never followed. Forts now cost 50 a day, ports 20
and airports 35, and every vehicle's upkeep is Main's. The flat car and
open passenger car Main already lists are added too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 43 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 88d1cda4-9b86-4c48-bc87-0dc588b156d0
📥 Commits

Reviewing files that changed from the base of the PR and between 2158704 and 57ba02b.

📒 Files selected for processing: 1
  • src/main/resources/vehicles.yml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:M 30-99 effective changed lines (tests excluded in mixed PRs). label Oct 20, 2026
The 30/15/20 upkeep in the repo is the intended rebalance from #105;
Main still had the values from before it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Drefvelin Drefvelin changed the title Match default installation and vehicle upkeep to Main Match default vehicle upkeep to Main Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant