Repository navigation
UI bug fixes - #60
Open
iamrajeshk wants to merge 3 commits into
Open
UI bug fixes#60iamrajeshk wants to merge 3 commits into
iamrajeshk wants to merge 3 commits into
Conversation
…is loaded and add unit tests, Ui fixes
…nd MainActivity; implement cache clearing for quest types
…sts; add regression test for cache clearing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the visibility logic for the "Show Quest Forms" action in the user profile screen by ensuring it only appears when relevant quest forms are available (i.e., after a workspace is loaded). It also adds tests for this behavior and makes a minor UI improvement in the workspace activity.
Quest Forms Action Visibility Logic:
showQuestFormsActionOrNullinUserActivity.ktto conditionally show the "Show Quest Forms" action only when theQuestTypeRegistryis not empty, reflecting the loaded state of a workspace.UserProfileScreencomposable and its usage to accept a nullableonClickShowQuestFormscallback, hiding the entry when there are no quest forms to show. [1] [2] [3]Testing:
ShowQuestFormsActionTest.ktto verify that the "Show Quest Forms" action is shown or hidden appropriately based on the state of theQuestTypeRegistry.UI Improvements:
MaterialTheme.colorScheme.onSurfaceVariantfor better visual consistency. [1] [2]