Skip to content

Feat/guest profession location comboboxes - #403

Merged
telivity-otaip merged 4 commits into
TelivityAI:mainfrom
Gugabit:feat/guest-profession-location-comboboxes
Nov 9, 2026
Merged

telivity-otaip merged 4 commits into
TelivityAI:mainfrom
Gugabit:feat/guest-profession-location-comboboxes

Conversation

@Gugabit

@Gugabit Gugabit commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

Summary:

  • Replaces free-text inputs with searchable, keyboard-navigable Combobox.tsx components.
  • Professions: professions database table and /v1/professions API pre-populated with Brazilian CBO occupations and property custom values.
  • Location: Autocomplete for Cities, States, and Countries integrated into guest registration modals and details.

@cursor

cursor Bot commented Nov 8, 2026

Copy link
Copy Markdown

Hey @Gugabit — thank you for the profession/location combobox work. Solid guest-registration UX.

We're going to land a small maintainer hardening pass on the professions API inside this PR (honest global catalog + write permissions, drop unused propertyId, tighten metadata), then get CI green — still your feature and your credit. Appreciate you.

Gugabit and others added 4 commits November 9, 2026 07:42
Treat professions as a shared catalog: drop unused propertyId DTO fields,
require guests.write on create, validate metadata as an object, and document
that official CBO/SOC seed is a follow-up rather than part of this migration.

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
Accounts for ProfessionService and Combobox suites.

Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
@cursor

cursor Bot commented Nov 9, 2026

Copy link
Copy Markdown

Update: rebased onto latest main, then a maintainer hardening pass on the professions API inside this PR:

  • Honest global catalog (dropped unused propertyId DTO fields that looked tenant-scoped but weren’t)
  • POST /v1/professions now requires guests.write
  • metadata validated with @IsObject()
  • Documented that official CBO/SOC seed is a follow-up (migration creates the empty table; find-or-create still works from guest registration)

Synced test counts. Waiting on CI — still your feature and credit. Thanks again for this one.

@cursor
cursor Bot force-pushed the feat/guest-profession-location-comboboxes branch from f042ad9 to 7f92946 Compare November 9, 2026 07:43
@telivity-otaip
telivity-otaip merged commit 99463ea into TelivityAI:main Nov 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants