Repository navigation
fix(admin): collapse duplicate global system roles on list and prevent seed re-insertion - #405
Merged
Merged
Conversation
…t seed re-insertion Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
Select the representative global system role using each candidate’s own property-scoped role_permissions, prefer the richest set (canonical ee000001-* on ties), and return only that ID’s permissions. Custom property-scoped roles stay distinct. Regression tests cover overlapping unequal sets and list hydration without cross-ID bleed. Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
CI rejected stale README/docs/test-stats.json after the roles.service regression cases landed (actual Vitest totals 2677 / 314). Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isSystem/propertyId == null) bykeyinRolesService.list/dedupeSystemRoleswhile keeping every property-scoped custom role distinct byid.role_permissions(richest set wins; canonicalee000001-*on a tie). Return only the selected ID’s permissions — never a union across discarded duplicates.property_id IS NULLsystem role row bykeybefore inserting (no role deletion/migration).Verification
vitest run src/modules/admin/roles.service.spec.ts(9/9) and admin module suite (19/19).README.md+docs/test-stats.jsonfor the stale published-count gate.