Repository navigation
Remove asap7/mock-cpu and designs/src/fifo - #4701
Merged
maliberty merged 1 commit intoOct 20, 2026
Merged
Conversation
asap7/chi_async_bridge replaces asap7/mock-cpu. CI no longer builds mock-cpu. No other design reads designs/src/fifo. Update the chi_async_bridge README, which named mock-cpu as the only other design with a timed asynchronous crossing. Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the mock-cpu design from the asap7 platform, deleting all of its associated configuration, constraint, RTL, and testbench files. Additionally, it updates the chi_async_bridge README to remove references to the deleted mock-cpu design. There are no review comments, so I have no feedback to provide.
oharboe
approved these changes
Oct 19, 2026
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 1 without a comparable baseline. |
maliberty
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete
asap7/mock-cpuanddesigns/src/fifo.asap7/chi_async_bridgereplaces them (#4600).CI's design list no longer names
asap7/mock-cpu.That was the condition set in #4600 for this follow-up.
designs/src/fifowas read only byasap7/mock-cpu.designs/src/mock-array/util.tclstays, because other designs use it.The
chi_async_bridgeREADME namedasap7/mock-cpuin two table rows.Both rows now say "none".