Skip to content

sorts: make recursive mergesort generic for comparable items - #15406

Merged
cclauss merged 1 commit into
TheAlgorithms:masterfrom
ColumbusLabs:fix/python-15234-recursive-mergesort
Sep 23, 2026
Merged

cclauss merged 1 commit into
TheAlgorithms:masterfrom
ColumbusLabs:fix/python-15234-recursive-mergesort

Conversation

@ColumbusLabs

@ColumbusLabs ColumbusLabs commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Describe your change

sorts/recursive_mergesort_array.py now sorts any mutually comparable items, not only integers. It accepts an iterable, copies it, and returns a new list. Doctests cover strings, mixed floats and ints, a non-list iterable, and the TypeError raised when items cannot be compared. tests/test_sorts.py runs this sort through the shared comparison-sort cases, including the non-comparable failure.

Part of #15234

How this was verified

python3 -m doctest -v sorts/recursive_mergesort_array.py
python3 -m pytest tests/test_sorts.py sorts/recursive_mergesort_array.py -q --tb=short
python3 -m ruff check sorts/recursive_mergesort_array.py tests/test_sorts.py

Doctest: 12 passed. Pytest: 297 passed. Ruff: all checks passed. These ran with Python 3.12.3. The repository targets Python 3.14; that interpreter was not available locally.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Accept any iterable of mutually comparable items and return a new list.
Part of TheAlgorithms#15234

@cclauss cclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cclauss
cclauss marked this pull request as ready for review September 23, 2026 06:10
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Sep 23, 2026
@cclauss
cclauss merged commit cce4d26 into TheAlgorithms:master Sep 23, 2026
6 checks passed
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants