bugfix(worldbuilder): Keep new and resized maps within the map size limit

[tintinhamans]

⚠️ Merge after: #3486

---

The new map and resize dialog accepts any size, so WorldBuilder could create and save maps the loader rejects. isValidMapSize now applies MAX_MAP_DIMENSION and MAX_MAP_AREA to the map plus its border in the dialog, resize and the saved defaults, and the dialog warns above 1024x1024.

resize also frees its arrays with delete[] and clears the new flip and cliff state.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 8e976b83-f7a2-4c62-aef0-41e3046edd65

📥 Commits

Reviewing files that changed from the base of the PR and between 679d8f2 and 17859d5.

📒 Files selected for processing: 4

• Generals/Code/Tools/WorldBuilder/src/NewHeightMap.cpp
• Generals/Code/Tools/WorldBuilder/src/WHeightMapEdit.cpp
• GeneralsMD/Code/Tools/WorldBuilder/src/NewHeightMap.cpp
• GeneralsMD/Code/Tools/WorldBuilder/src/WHeightMapEdit.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

Both WorldBuilder variants add shared map-size validation. The check is used when constructing or resizing maps, submitting new-map dimensions, and applying configured defaults. Resizing also changes height-data allocation and array handling.

Changes

Height-map validation

Layer / File(s)	Summary
Editor validation and resizing Generals*/Code/Tools/WorldBuilder/include/WHeightMapEdit.h, Generals*/Code/Tools/WorldBuilder/src/WHeightMapEdit.cpp	Both variants add isValidMapSize and use it for construction and resizing. Resizing allocates an extra row for height data, uses array deletion, and zero-initializes new cliff and flip state arrays.
Map creation and default dimensions Generals*/Code/Tools/WorldBuilder/src/NewHeightMap.cpp, Generals*/Code/Tools/WorldBuilder/src/WorldBuilderDoc.cpp	New-map dialogs reject invalid dimensions and prompt for confirmation when the border-inclusive area exceeds 1024 × 1024. New-document setup resets invalid extents to 100 × 100 and the border width to 30.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Suggested reviewers: cryotherenegade

Merge Risk: ⚪ Minimal · up to 17859

The reported overflow concern cannot occur under the current map-size limits. No actionable merge-blocking risk is established.

Pre-merge checks: 4

Check name	Status	Explanation
Description check		The description accurately summarizes the map-size validation, 1024×1024 warning, array deallocation, and state initialization changes.
Title check		The title clearly identifies the main change: keeping new and resized WorldBuilder maps within the map-size limit.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

This PR keeps new and resized maps within the loader’s size limits in both WorldBuilder versions.

• New and resized maps stay within the loader’s size limits.
• The size dialog warns before maps exceed 1024 × 1024 cells.
• Resizing gives map data extra space and clears its cell flags.

No actionable new issues were found.

_{Reviews (7) · Last reviewed commit: "bugfix(worldbuilder): Keep new and resiz..." · Reviewed by Greptile}

[Mauller]

As WWB2 mentioned in the other PR, we might want to limit the map Area rather than hard limit dimensions, since it's the overall area that causes problems and not just individual dimensions.

So the Max area being 4096 squared etc

[tintinhamans]

As WWB2 mentioned in the other PR, we might want to limit the map Area rather than hard limit dimensions, since it's the overall area that causes problems and not just individual dimensions.

So the Max area being 4096 squared etc

The limit is now an area of 4096x4096. Each side is still capped at 8192 because shoreline tiles pack coordinates into 16 bits and the shroud texture spans the map.

[Mauller]

LGTM

[xezon]

Needs rebase?