Skip to content

fix(pipeline_schedules): discard stale pages after account or refresh changes - #678

Open
sjungwon03 wants to merge 2 commits into
devfrom
fix/677-schedule-list-generation
Open

sjungwon03 wants to merge 2 commits into
devfrom
fix/677-schedule-list-generation

Conversation

@sjungwon03

@sjungwon03 sjungwon03 commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Discard stale pipeline schedule page results after an account change or list refresh.
  • Reset pagination state when the list rebuilds and guard success, error, and loading state by build generation.
  • Add four delayed-page regressions for account changes and refreshes, covering successful and failed old requests.

Closes #677

Verification

  • Test-only commit bb23df4 failed all four new regressions as expected in CI run 40699247559; formatting and analysis passed.
  • Fix commit e6d6213 passed formatting, analysis, app and package tests, generated-code verification, language policy, and iOS SDK validation in CI run 40701118643.
  • Local git diff --check passed. Flutter and Dart are unavailable locally.

… refresh

Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
@github-actions github-actions Bot added the fix Bug fix label Oct 28, 2026
Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
@github-actions github-actions Bot added the area:ui Screens and feature UI label Oct 28, 2026
@sjungwon03
sjungwon03 marked this pull request as ready for review October 28, 2026 13:59
@sjungwon03 sjungwon03 mentioned this pull request Oct 28, 2026

@sjungwon03-ai sjungwon03-ai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

Verdict: Approved

  • Reviewed: Complete controller and test diff, repository/account dependency context, generation guards for stale pagination success and failure, loading-state ownership, and four account-switch/refresh regressions; no blocking issues found.
  • Checks: Current-HEAD CI passed formatting, analysis, tests, generated-code verification, language policy, and iOS SDK validation; triage passed, with its issue-only job skipped. Flutter and Dart are unavailable locally, so tests were not rerun locally.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ui Screens and feature UI fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discard stale pipeline schedule pages after account changes or refresh

2 participants