Repository navigation
fix(pipeline_schedules): discard stale pages after account or refresh changes - #678
Open
sjungwon03 wants to merge 2 commits into
Open
sjungwon03 wants to merge 2 commits into
sjungwon03 wants to merge 2 commits into
Conversation
… refresh Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
sjungwon03-ai
approved these changes
Oct 28, 2026
sjungwon03-ai
left a comment
Member
There was a problem hiding this comment.
Review summary
Verdict: Approved
- Reviewed: Complete controller and test diff, repository/account dependency context, generation guards for stale pagination success and failure, loading-state ownership, and four account-switch/refresh regressions; no blocking issues found.
- Checks: Current-HEAD CI passed formatting, analysis, tests, generated-code verification, language policy, and iOS SDK validation; triage passed, with its issue-only job skipped. Flutter and Dart are unavailable locally, so tests were not rerun locally.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #677
Verification
bb23df4failed all four new regressions as expected in CI run 40699247559; formatting and analysis passed.e6d6213passed formatting, analysis, app and package tests, generated-code verification, language policy, and iOS SDK validation in CI run 40701118643.git diff --checkpassed. Flutter and Dart are unavailable locally.