Repository navigation
Preserve hidden repositories in bulk reads - #541
Merged
tinder-maxwellelliott merged 1 commit intoOct 22, 2026
Merged
Conversation
The bulk show_repo reads introduced in 998fb78 match selected canonical names, but hidden modules are selected by module key. Their records therefore disappear from large selections, breaking repository dependency paths. Keep hidden module keys on the explicit path and append those records after the selected canonical records. Rebuild canonical results in selection order, exclude known failed extensions, and check cancellation before falling back to explicit reads. The generation also repeated successful root mapping and Bazel version lookups and cloned collected repository targets on the successful ordinary query path. Reuse those lookups and move the targets into the result. Codex for Tamir.
tamird
force-pushed
the
tamird/bulk-repository-reads
branch
from
October 22, 2026 19:16
b547b11 to
0889a89
Compare
tamird
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bulk show_repo reads introduced in 998fb78 match selected canonical names, but hidden modules are selected by module key. Their records therefore disappear from large selections, breaking repository dependency paths.
Keep hidden module keys on the explicit path and append those records after the selected canonical records. Rebuild canonical results in selection order, exclude known failed extensions, and check cancellation before falling back to explicit reads.
The generation also repeated successful root mapping and Bazel version lookups and cloned collected repository targets on the successful ordinary query path. Reuse those lookups and move the targets into the result.
Codex for Tamir.