Repository navigation
Conversation
samgbafa
force-pushed
the
skgbafa/tc-2917-chunked-artifacts
branch
5 times, most recently
from
November 13, 2026 22:44
5759367 to
d033bc4
Compare
samgbafa
force-pushed
the
skgbafa/tc-2917-chunked-wal
branch
from
November 14, 2026 01:41
1993c42 to
aa76999
Compare
samgbafa
changed the base branch from
skgbafa/tc-2917-chunked-artifacts
to
main
November 14, 2026 01:41
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQL databases using artifact parts now persist a cumulative WAL without rewriting their checkpoint after each mutation. The actor hands off an owned WAL file; each payload statement carries at most 1 MiB. A short conditional publication advances the revision and WAL pointer while retaining the checkpoint. Full checkpoints replace both parts when needed. Details: TC-2917.
Stacked on #582; this PR targets its branch until that prerequisite merges. The feature remains off by default and this is not an enablement request.
Validation (private HOME/TC_HOME, owned PostgreSQL 18.6, assigned slot, -j2/debug off): 18 targeted PostgreSQL tests pass, including SQL save→WAL→empty-cache restart with exact recovered bytes, unchanged checkpoint bytes, forced-checkpoint collection of both old parts, WAL corruption, stale publication, combined-size limits and quota accounting. Core/test and server Clippy pass with warnings denied. All 1,111 core tests pass with PostgreSQL configured. A deliberate omission of the WAL CID check fails the corruption assertion; source restored afterwards.
test-ruling: TC-2917 — Naomi approved updating this PR’s own checkpoint-only smoke to count checkpoint plus WAL chunks, assert a nonempty WAL and unchanged checkpoint ids/bytes, then force a checkpoint and prove both superseded parts are reclaimed. No other existing tests edited.
Remaining separate work: DuckDB chunk writes, existing-artifact conversion and ceiling-load acceptance. Flag stays off. No production actions.