Repository navigation
Conversation
samgbafa
force-pushed
the
skgbafa/tc-2990-duckdb-wal-base
branch
from
November 13, 2026 23:47
441b13b to
56a0a69
Compare
…AL fast path and same-length reuse Review of #594: with no recorded lineage a WAL is attached only to the checkpoint it was verified against; new tests pin that repeated small writes stay on the WAL path and that a same-length rewrite of freed blocks recovers exact rows.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large file-backed DuckDB inserts can write new blocks into the main file while the WAL records references to them. Saving that WAL beside an older checkpoint cannot recover the acknowledged data after eviction or restart. DuckDB now uses the WAL path only when the local main file's length and Blake3 CID match the stored checkpoint; otherwise it saves a complete checkpoint. Details: TC-2990.
The identity check and WAL copy run under the actor fence. Hashing uses a 64 KiB buffer; the existing revision/checkpoint publication guard remains intact. Unchanged-file small writes keep incremental persistence.
Validation:
8802d3bb: an acknowledged 300,000-row insert fails fresh-cache recovery withCould not read enough bytes.