Repository navigation
Conversation
samgbafa
pushed a commit
that referenced
this pull request
Nov 13, 2026
Renaming aside needs the held registration, releasing it consumes the entry, and only the released form can be deleted: reordering either step no longer compiles (#601 review C2).
Evicted actors rename their cache files aside under the registration and delete them after releasing it; leftover spill directories no longer block hydration or discard; failed imports leave no staged or imported file; shutting down an exited actor succeeds.
Renaming aside needs the held registration, releasing it consumes the entry, and only the released form can be deleted: reordering either step no longer compiles (#601 review C2).
samgbafa
force-pushed
the
skgbafa/tc-2917-part-lifecycle
branch
from
November 14, 2026 01:41
00d516f to
c441b37
Compare
samgbafa
force-pushed
the
skgbafa/tc-2917-duckdb-fs-cleanup
branch
from
November 14, 2026 01:41
80729de to
327b09c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #597 for TC-2917. Chunked artifact storage stays disabled by default.
DuckDB cache files are cleaned up without holding up other databases, and failures leave nothing behind:
Validation:
Remaining before enabling: DuckDB disk bounds (headroom and spill limit; follow-up stacked on this PR), existing-database conversion, and ceiling-load acceptance. This PR does not enable the feature.
Test-ruling: TC-2917. No existing test is edited. New tests, adopted from the #591 security review's probes: