Repository navigation
TC-2917: chunked read follow-ups: fallback slot test, bounded slot test, sinks declare buffering - #604
Open
samgbafa wants to merge 1 commit into
Open
TC-2917: chunked read follow-ups: fallback slot test, bounded slot test, sinks declare buffering#604samgbafa wants to merge 1 commit into
samgbafa wants to merge 1 commit into
Conversation
… declare buffering Review of #582: a new test pins that a parts read falling back to the single-row layout releases its slot first and keeps the legacy cap and slot; the streaming read in the in-memory slot test is bounded so a regression fails instead of hanging; ArtifactSink::buffers_in_memory has no default, so a new or wrapping sink must declare it; docs say the capacities are checked at write time and name the in-memory case correctly.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TC-2917. Follow-up to #582: tests, a fail-closed sink contract, and doc wording. No production behaviour changes; chunked artifact storage stays off.
Changes
ArtifactSink::buffers_in_memoryhas no default. Every sink now has to say whether it holds the whole artifact in memory. Before, a new sink or a wrapper that forgot the method answered "no" and took no large-transfer slot. The memory sink answers yes and the cache-file sink answers no, as before; existing test sinks answer no (their behaviour is unchanged).postgres_chunked_fallback_to_legacy_holds_no_parts_slot: a read whose metadata says parts but whose row is single-payload falls back to the single-row read. The test checks three things:postgres_chunked_in_memory_read_waits_for_a_large_transfer_slot, the streaming read is wrapped in a 30 s timeout, so a regression that makes it wait for a slot fails instead of hanging the job.Validation (local PostgreSQL 18.6): core lib with
duckdb1181/1181; clippy core (duckdb) and node with-Dwarnings; fmt. Throwaway mutations, each now caught: the slot taken for streaming sinks fails the bounded test (it used to hang); the parts slot held into the legacy fallback fails the new fallback test; the legacy cap and slot taken before the parts attempt fails three tests.Test-ruling: TC-2917. Two existing-test changes:
postgres_chunked_in_memory_read_waits_for_a_large_transfer_slot: its streaming read is wrapped in a 30 stokio::time::timeout, failing withElapsed. Nothing else in the test changes.buffers_in_memoryreturningfalse, the former default. This is a compile-only change.