Repository navigation
Conversation
…point back-off, size probe, chain-guard wait and http_5xx; vendor canonical schema (TC-3006)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: TC-3006, with TC-2954, TC-2961 and TC-3027. Targets 1.26.7; node main is frozen for the 1.26.6 cut. Canonical schema: tinycloud-dev-sam #336 (stacked on #334).
Behaviour
The log sidecar classifies six node warnings that it used to ship as
unclassified. Each ships as a per-minute count (event_codeandevent_countonly), like every other classified diagnostic. None of its fields leaves the node.tinycloud_core::db_pool)db_pool_closed_in_transactiontinycloud_core::sql::service)sql_database_too_large_to_loadtinycloud_core::sql::service)sql_checkpoint_save_backoffkv_head_size_probe_failedtinycloud::chain_guard)chain_guard_slow_waittinycloud::request)http_5xxsqlx_core::pool::connectionwould never classify. It now carriestarget: "tinycloud_core::db_pool"; this is recorded invendor/sqlx-core/PATCH.md. The shipper's target allowlist is unchanged.chain_guard_slow_wait. It ships as a count, not as a capped class with its ownerrors_dropped. A per-minute cap does not fit the TC-1843 reserve: 585.4 MB is used of 600 MB, and even one event per minute adds ≈ 17.4 MB. The arithmetic is in tinycloud-dev-sam feat(TC-887): seal KV blocks in the S3 store (S3c, stacked on #333) #336. The node already limits the line to one per second per process.http_5xx. It ships as a count. Each 5xx request already ships on its own under thenode_request_5xxcap, so a separate event per 5xx would count it twice.Schema and config
log-shipper/fields.json: byte for byte the canonical file at tinycloud-dev-sam 6f0d4202 (feat(TC-887): seal KV blocks in the S3 store (S3c, stacked on #333) #336). That is canonical main plus ci(TC-887): resolve the w5 workspace with --locked using a policy-engine deploy key #334'snode_storage_headroom(already pinned here by feat(TC-2917): disk headroom as a shipped log event and metrics #600) plus feat(TC-887): seal KV blocks in the S3 store (S3c, stacked on #333) #336. It brings TC-2075/TC-2076'schain_guard_slow_waitcode and fields, without the class, and TC-2073'shttp_5xx. Pinned inlog-shipper/canonical.json(sha256c72f50d8…). Once ci(TC-887): resolve the w5 workspace with --locked using a policy-engine deploy key #334 and feat(TC-887): seal KV blocks in the S3 store (S3c, stacked on #333) #336 merge, the pin moves to the canonical main merge commit; the bytes don't change.log-shipper/diagnostics.json: the six message → code entries.docker-compose.dstack-postgres.yamland its fixturescripts/ci/fixtures/tc959-n0-compose.yaml. The generator reproduces main's current line byte for byte before the change.90841a34…(raw5419a6fb…) toefad41d56df187a7e0ddd1a13f3c4a3c436ad7c0ff141acd32c06e28f9c92a34(raw7ee085c6e5da8a2b7a6e77fa207089b4cef3b8c291b4770f0d0c3336449f90b1), in.github/workflows/docker.ymlanddocs/releasing.md. The release notes must state the change.Tests
log-shipper/cases.mjs: each of the six lines maps to its code with only the six fixed keys, while extra fields and canaries are dropped. Near-misses stayunclassified: a suffix, a lowercase variant, a truncated message, and the backstop message on the oldsqlx_core::pool::connectiontarget.node --test log-shipper/budget.test.mjs log-shipper/profile.test.mjs scripts/tc959-docker.test.mjs scripts/tc959-readiness.test.mjs: 41/41 pass.node scripts/tc959-check.mjspasses.vector test: errors_slow 281/281, all_requests 281/281, including the new cases.native-check.mjs: passed, with 0 console canary hits and wire_safe.cap-check.mjs: passed. The five caps are unchanged and there is nochain_guard_slow_waitcap.vector validateon the rendered runtime config: Validated.cargo check -p sqlx-corepasses for the one-line vendor change.