Repository navigation
test(frontend): cover map layers, relay details dialog and family selection dialog - #575
Merged
Merged
Conversation
…ection dialog Adds integration tests for LeafletLayers (statistics, aggregation, heat map, country and family grouping, marker clicks), the relay details dialog on large and small screens (single relay, list, search, quick actions, failure paths, paging) and the family selection dialog. Adds details and family fixtures. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Visit the preview URL for this PR (updated for commit 3d91907): https://tormap-36f44--pr575-chore-frontend-dialo-xls65sbp.web.app (expires Mon, 09 Nov 2026 15:00:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 0c1f71965de18e60b0e686b0d0356977fec090dc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fifth step of the frontend testing plan (follows #570, #571, #573, #574). Tests the interaction flows around the map.
LeafletLayers.test.tsx: statistics and filtered relay reporting, marker/hover target drawing, no draw before data, the no-relays warning, coordinate aggregation, heat layer on/off, country grouping (polygons, click to select, stale selection reset), family grouping (no data warning, direct selection, picking between families through the family dialog, stale selection reset, deselect), and a marker click opening the details dialog. Layer clicks fire on the real Leaflet layers found through the map.ResponsiveRelayDetailsDialog.test.tsx(large and small screens): single relay details, number/flag formatting, list of several relays and choosing one, search and auto-select of a single match, empty search, quick actions (restrict to relay type, select family), missing details warning, failed list and details lookups, back navigation on small screens, batch rendering of long lists.FamilySelectionDialog.test.tsx(large and small): table of families, selecting a row, reload when families are outdated, failed lookup, no lookup without families.src/test/fixtures.ts:makeRelayDetails,makeRelayIdentifier,makeFamilyIdentifier.No production code changed.
Notes for reviewers
toHaveTextContentwith a regular expression does not match in Vitest browser mode here, so those assertions useexpect.poll(...).toMatch.Coverage
Whole project: 93.0% lines, 87.9% branches, 88.3% functions (was 76.7% lines / 56.0% branches). Remaining gaps are mostly the settings/date/overlay/about components, which are the next PR.
Deployment notes
None.
Dependency vetting
No dependency changes.
Verification (Node 24)
tscclean, eslint clean.🤖 Generated with Claude Code