Repository navigation
Own --tests_url/--tests_dir in the sweep instead of failing on position - #52
Merged
Merged
Conversation
`--tests_url` belongs to the harness's `download` subcommand, and the sweep puts passthrough arguments in front of the subcommand, so passing it after `--` dies on "unrecognized arguments" -- an error that says the flag is wrong when only its position is. That is a bad failure to hand someone editing a CronJob manifest by hand, where the feedback loop is a deploy. The sweep already had --tests_url and just needed to say so; --tests_dir, its `load` counterpart, was missing entirely, so a sweep over a suite outside the bundled directory had no way to say where it lived. Add it, place both after their subcommand where argparse accepts them, and reject either one appearing in the passthrough with an error naming the flag and where it goes. The CronJob example now also spells out that --performance_profile is the only thing selecting which queries HelmsDeep sends. The suite's test assets don't, so a job named for pathfinder tests but running the `default` profile measures inferred queries instead -- and nothing about its output would say so. Verified against a locally served suite zip: downloaded from a custom URL, parsed, ran, exit 0; and the misplaced form now stops with the guidance instead of the harness's own error. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uu7mLrTmyXzLSY8kyR3tjD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--tests_urlbelongs to the harness'sdownloadsubcommand, and the sweep puts passthrough arguments in front of the subcommand, so passing it after--dies on "unrecognized arguments" -- an error that says the flag is wrong when only its position is. That is a bad failure to hand someone editing a CronJob manifest by hand, where the feedback loop is a deploy.The sweep already had --tests_url and just needed to say so; --tests_dir, its
loadcounterpart, was missing entirely, so a sweep over a suite outside the bundled directory had no way to say where it lived. Add it, place both after their subcommand where argparse accepts them, and reject either one appearing in the passthrough with an error naming the flag and where it goes.The CronJob example now also spells out that --performance_profile is the only thing selecting which queries HelmsDeep sends. The suite's test assets don't, so a job named for pathfinder tests but running the
defaultprofile measures inferred queries instead -- and nothing about its output would say so.Verified against a locally served suite zip: downloaded from a custom URL, parsed, ran, exit 0; and the misplaced form now stops with the guidance instead of the harness's own error.
Claude-Session: https://claude.ai/code/session_01Uu7mLrTmyXzLSY8kyR3tjD