Repository navigation
ci: run editorconfig-checker - #1
Merged
Merged
Conversation
dangreen
force-pushed
the
ci/run-editorconfig-checker
branch
from
October 18, 2026 13:01
c947d36 to
a2b21ff
Compare
dangreen
force-pushed
the
ci/run-editorconfig-checker
branch
from
October 18, 2026 13:06
a2b21ff to
9640a24
Compare
dangreen
force-pushed
the
ci/run-editorconfig-checker
branch
from
October 18, 2026 13:40
9640a24 to
da503f2
Compare
dangreen
force-pushed
the
ci/run-editorconfig-checker
branch
from
October 18, 2026 13:56
da503f2 to
96553fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
editorconfigjob installseditorconfig-checkerbut never runs it: themainbranch ofeditorconfig-checker/action-editorconfig-checkeronly adds the binary toPATH, and the example workflow of the action runs it in a step of its own. The job has had no such step since it was added, so it has never checked a file.Run as is,
editorconfig-checkerv4.0.2 reports 91 errors, all from its indent-size rule, which wants every left-padding to be a multiple ofindent_size. They are 22 CSS comments continued under their own text, 14 lines of markdown aligned with the text above them, such as the content of a list item, 3 spaces after1., or a wrapped column of a table, and 55 lines of the installer's Python and sh aligned with the line above, mostly commands wrapped under their first argument..editorconfigsaid the rule was switched off in.editorconfig-checker.json, but that file was never added.What
/**and*/on lines of their own, with an asterisk at the start of every line between them. The text keeps its column, and every left-padding is even. The two comments inImageDrop.module.cssthat already had this layout now open with/**instead of/*.1.followed by two spaces, so the content sits at 4 spaces instead of 3. Aligned columns inREADME.mdandSPEC.mdmove one space right, to an even column, and the scores of the ranking example get a sign,+90next to-90, so they stay right-aligned.setup.shthe twozenitycalls continue at the column of thekdialogcalls next to them, and a branch ofcaseputs its commands on lines of their own, as does a block inmake-run.sh..editorconfigreaches the files insrc: its globpackages/installer/*.{py,sh}matchedmake-run.shalone, so editors and the check took 2 spaces for the rest.packages/installer/**.{py,sh}gives all of them 4..editorconfig-checker.jsongoes away.Install editorconfig-checker, and a newCheck editorconfigstep runseditorconfig-checker.Notes
indent_sizestays set, so every file is checked against it.sh -nanddash -naccept both scripts.mdast-util-from-markdownand its GFM extension.editorconfig-checkerv4.0.2 finds no errors onmain.