Repository navigation
feat(preact,preact-router,preact-ssr): support Preact 11 - #302
Merged
Merged
Conversation
Widen the `preact` peer range to `^10.0.0 || ^11.0.0` and move the Event Board example to Preact 11. Bump `preact-render-to-string` to 6.8, as Preact 11 needs 6.7 or newer.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
==========================================
+ Coverage 83.60% 83.62% +0.02%
==========================================
Files 228 228
Lines 4849 4849
Branches 1074 1074
==========================================
+ Hits 4054 4055 +1
+ Misses 554 553 -1
Partials 241 241 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #273.
@nano_kit/preact,@nano_kit/preact-routerand@nano_kit/preact-ssrsupport Preact 11 next to Preact 10: the peer range is^10.0.0 || ^11.0.0. The workspace develops and tests on Preact 11.<a>props as a union that tiesroletohref, so the<a>ofLink, which forwardsAnchorHTMLAttributes, no longer type-checks. Itshrefgets a@ts-expect-errorwith the reason. Casting the spreads instead passestscbut tripsno-unnecessary-type-assertion, which checks each spread on its own.LinkPropsstays as is, and the emitted JS is the same.preact-render-to-stringis^6.8.1in the catalog and in the example: Preact 11 declares>=6.7.0as its peer.@nano_kit/preact-ssronly calls the synchronousrender, so the streaming API change of 6.8 does not touch it.Size: the
All publicsbundles of@nano_kit/preact(720 B gzip, 662 B brotli) and@nano_kit/preact-router(1569 B gzip, 1469 B brotli) matchmainto the byte: Preact stays external, and theLinkfix is type-only. The documented size tables have no Preact rows, so nothing there needs a new measurement.