Repository navigation
ci: run editorconfig-checker - #52
Merged
Merged
Conversation
Coverage Report for CI Build 39132596265Coverage remained the same at 93.859%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
dangreen
force-pushed
the
ci/run-editorconfig-checker
branch
from
October 18, 2026 13:01
1508bfb to
b9c927b
Compare
dangreen
force-pushed
the
ci/run-editorconfig-checker
branch
from
October 18, 2026 13:40
b9c927b to
da706bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
editorconfigjob installseditorconfig-checkerbut never runs it: themainbranch ofeditorconfig-checker/action-editorconfig-checkeronly adds the binary toPATH, and the example workflow of the action runs it in a step of its own. The job has had no such step since it was added, so it has never checked a file.Run as is,
editorconfig-checkerv4.0.2 reports 16 errors, all from its indent-size rule, which wants every left-padding to be a multiple ofindent_size. They are 9 lines of numbered list items in two pages of the docs, which markdown aligns with the text of the item, 3 spaces after1., and 7 comments inwebsite/src/styles/global.csscontinued under their own text.What
/**and*/on lines of their own, with an asterisk at the start of every line between them. The text keeps its column, and every left-padding is even.1.followed by two spaces, so the content sits at 4 spaces instead of 3.Install editorconfig-checker, and a newCheck editorconfigstep runseditorconfig-checker.Notes
.editorconfigstays as it is, so every file is still checked againstindent_size.mdast-util-from-markdownand its GFM and MDX extensions.editorconfig-checkerv4.0.2 finds no errors onmain.