Skip to content

fix: silence original audio unavailable toast on single-language streams - #33

Merged
Priveetee merged 3 commits into
TypeType-Video:devfrom
Aquarius-Situla:fix/silence-single-language-original-audio-toast
Sep 26, 2026
Merged

Priveetee merged 3 commits into
TypeType-Video:devfrom
Aquarius-Situla:fix/silence-single-language-original-audio-toast

Conversation

@Aquarius-Situla

@Aquarius-Situla Aquarius-Situla commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Suppresses false-positive "Original audio unavailable" toast notifications on single-language streams (such as Bilibili DASH streams) by guarding original audio heuristic checks behind a multi-language track validation (#287).


Key Changes

Audio Track Language Notification Guard (apps/web/src/components/player-defaults.tsx):

  • Added a hasMultipleLanguages check using normalized audio track language tags.
  • Guarded missingOriginalByHeuristic and the onOriginalLanguageUnavailable?.() callback to ensure notifications only trigger when media has multiple distinct language tracks.
  • Resolves recurring false-positive warnings on single-language streams with multiple bitrate representations (e.g., Bilibili DASH streams).

@Priveetee

Copy link
Copy Markdown
Member

LGTM 😉

@Priveetee
Priveetee merged commit 83fc64e into TypeType-Video:dev Sep 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants