Repository navigation
fix: improve resolution height extraction and matching in QualitySelector and PlayerDefaults - #34
Merged
Priveetee merged 4 commits intoSep 26, 2026
Conversation
Member
|
LGTM, thx a lot for ur contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves issues where the video quality menu disappears and default quality matching fails on streams lacking
option.quality.heightby adding resolution fallbacks tooption.heightand parsed label heights (#287).Key Changes
Quality Selector Resolution Fallbacks (apps/web/src/components/quality-selector.tsx):
optionHeighthelper to resolve height acrossoption.quality?.height,option.height, and parsedqualityLabelHeight(option.label).option.quality?.heightchecks inqualityValueand visibility filters withoptionHeight, preventing the quality menu from erroneously hiding whenquality.heightis 0 or undefined.Default Quality Preference Matching (apps/web/src/components/player-defaults.tsx):
qualityLabelHeight(o.label)inheightMatchwheno.quality?.heightis unpopulated.