Skip to content

fix: improve resolution height extraction and matching in QualitySelector and PlayerDefaults - #34

Merged
Priveetee merged 4 commits into
TypeType-Video:devfrom
Aquarius-Situla:fix/player-quality-resolution-matching
Sep 26, 2026
Merged

Priveetee merged 4 commits into
TypeType-Video:devfrom
Aquarius-Situla:fix/player-quality-resolution-matching

Conversation

@Aquarius-Situla

@Aquarius-Situla Aquarius-Situla commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Resolves issues where the video quality menu disappears and default quality matching fails on streams lacking option.quality.height by adding resolution fallbacks to option.height and parsed label heights (#287).


Key Changes

Quality Selector Resolution Fallbacks (apps/web/src/components/quality-selector.tsx):

  • Added optionHeight helper to resolve height across option.quality?.height, option.height, and parsed qualityLabelHeight(option.label).
  • Replaced strict option.quality?.height checks in qualityValue and visibility filters with optionHeight, preventing the quality menu from erroneously hiding when quality.height is 0 or undefined.

Default Quality Preference Matching (apps/web/src/components/player-defaults.tsx):

  • Added fallback to qualityLabelHeight(o.label) in heightMatch when o.quality?.height is unpopulated.
  • Ensures user-configured default quality preferences (e.g., 1080p) are reliably matched and elevated upon video load across all stream types (#287).

@Priveetee

Copy link
Copy Markdown
Member

LGTM, thx a lot for ur contribution :)

@Priveetee
Priveetee merged commit 8f83a0f into TypeType-Video:dev Sep 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants