Repository navigation
Feature eupl - #2
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Critical licensing attribution issues and documentation changes require resolution and human review.
Pull request overview
This PR changes the licensing metadata to EUPL-1.2 and adds REUSE compliance support.
Changes:
- Adds SPDX metadata and EUPL/CC0 license texts.
- Adds REUSE configuration and CI validation.
- Updates documentation and removes the former root license file.
File summaries
| File | Summary |
|---|---|
van_genuchten.h |
Adds SPDX metadata. |
van_genuchten.cpp |
Adds SPDX metadata. |
tests/richards_unit_test.cpp |
Adds SPDX metadata and a build command. |
richards_plugin.cpp |
Replaces the historical license header. |
richards_linker.h |
Replaces the historical license header. |
richards_elem_disc.h |
Adds SPDX metadata. |
REUSE.toml |
Adds repository license annotations. |
README.md |
Documents EUPL licensing and build instructions. |
LICENSES/EUPL-1.2.txt |
Adds the EUPL license text. |
LICENSES/CC0-1.0.txt |
Adds the CC0 license text. |
LICENSE |
Removes the former license text. |
json_basics.hh |
Adds SPDX metadata. |
CMakeLists.txt |
Adds SPDX metadata and replaces the historical header. |
.github/workflows/reuse.yml |
Adds REUSE compliance checking. |
Review details
- Files reviewed: 14/14 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1
to
+4
| # SPDX-FileCopyrightText: 2025 Goethe Universitaet Frankfurt | ||
| # SPDX-License-Identifier: EUPL-1.2 | ||
| # SPDX-FileContributor: Arne Naegel | ||
| # SPDX-FileType: SOURCE |
Comment on lines
+1
to
+4
| /* SPDX-FileCopyrightText: 2025 Goethe Universitaet Frankfurt | ||
| * SPDX-License-Identifier: EUPL-1.2 | ||
| * SPDX-FileContributor: Arne Naegel | ||
| * SPDX-FileType: SOURCE |
Comment on lines
+1
to
+4
| // SPDX-FileCopyrightText: 2025 Goethe Universitaet Frankfurt | ||
| // SPDX-License-Identifier: EUPL-1.2 | ||
| // SPDX-FileContributor: Arne Naegel | ||
| // SPDX-FileType: SOURCE |
Updated comments for clarity and formatting. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing to EUPL license.