Repository navigation
fix: ship regenerated block editor bundle and title-only page search (follow-up to #2014) - #2036
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Title-only page search inc/builders/block-editor/assets/js/blocks.js, inc/class-ajax.php |
The block editor and AJAX page queries now set search_columns to post_title. |
Module JavaScript minification and validation scripts/uglify.js, .github/workflows/pr-build-test.yml |
The minification script selects JavaScript under inc/**/assets/js. The CI check now includes minified JavaScript under inc/*/assets/js. |
Documentation and Comment Updates
| Layer / File(s) | Summary |
|---|---|
Hook references and page ID comment inc/documentation/berlindb-dynamic-hooks.php, inc/ui/class-base-element.php |
Hook source line references were updated across the documented sections. A comment now describes normalization to integer page IDs. |
Priority:
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Bug fix
Possibly related PRs
- Ultimate-Multisite/ultimate-multisite#2026: Adds the committed minified-asset check that this PR extends to module assets.
- Ultimate-Multisite/ultimate-multisite#2014: Introduces the page-search controls and AJAX endpoint updated here.
- Ultimate-Multisite/ultimate-multisite#2035: Regenerates Selectize assets and relates to the minified-asset validation updated here.
Suggested labels: bug
Merge Risk: 
7ffa0
-
The PR is mergeable; the reviewed documentation concern was refuted.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surv… Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title names two changes the PR makes: shipping a regenerated block editor bundle (blocks.min.js and selectizer.min.js) and limiting page search to titles. Both appear in the raw summary and object… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title names two changes the PR makes: shipping a regenerated block editor bundle (blocks.min.js and selectizer.min.js) and limiting page search to titles. Both appear in the raw summary and objectives, and the title is specific enough for a teammate to see the main change. It does not describe the minification script or the documentation regeneration in detail, which is acceptable.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 3 functions across 5 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
🔨 Build Complete - Ready for Testing!📦 Download Build Artifact (Recommended)Download the zip build, upload to WordPress and test:
🌐 Test in WordPress Playground (Very Experimental)Click the link below to instantly test this PR in your browser - no installation needed! Login credentials: |
Follow-up to #2014. Ref #1720
Summary
wu_get_asset()serves*.min.jswheneverSCRIPT_DEBUGis off, butinc/builders/block-editor/assets/js/blocks.min.jshad not been regenerated since the initial commit. With perf: defer editor settings and search page choices on demand #2014 merged, production editors loaded the stale bundle, which knows nothing aboutpage_search, so the three element page selectors offered only the default "Current Page"/"Default" choice and saved page IDs had no matching option.scripts/uglify.jsnow also minifies module assets underinc/**/assets/js, so the release build cannot ship a stale editor bundle again.inc/*/assets/js/*.min.js.blocks.min.jsandassets/js/selectizer.min.js(the latter was also stale after perf: defer editor settings and search page choices on demand #2014 and would have failed the freshness check on the next PR).search_columns) in both the Selectize endpoint (inc/class-ajax.php, WP 6.2+) and the block editor REST query (blocks.js, WP 6.5+). Both UIs filter results by title on the client, so content-only matches used up the 10/20-result cap and were then hidden. Older WordPress versions ignore the argument.get_page_search_field()'s options resolver (views/admin-pages/fields/field-select.phpcompares option keys strictly).Not changed
The #2014 review flagged possible duplicate
render_selectize_templatesfooter output when several elements render customize controls. WordPress deduplicates identical callbacks at the same priority inadd_action(), so the templates print once; no change needed.Verification
pnpm run uglify→ onlyselectizer.min.jsandblocks.min.jschanged; both contain the new code and passnode --check.git ls-files -- 'inc/*/assets/js/*.min.js'matchesblocks.min.js(freshness pathspec).vendor/bin/phpunit --filter 'Ajax_Test|Base_Element_Test|Block_Editor_Widget_Manager_Test'→ OK (74 tests, 208 assertions).blocks.js) pass. The ESLint findings inscripts/uglify.jsalready existed; that file is outside the lint scope.aidevops.sh v3.39.49 plugin for OpenCode
Summary by CodeRabbit