Repository navigation
LED settings: the colours of this box (#185) - #186
Merged
Merged
Conversation
With signature checking on, the sentence about the signature sat in the middle of the note and split its text into pieces that are in no translation. Each sentence is an element of its own now, with its own text in the catalogue (all nine languages, taken from the existing translations of the whole note). Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sb3gb1FHs6DNkZHKinKAJv
Found with a rendered check of System -> Firmware in every state and all
nine languages:
- the step shown while writing was one text with its ' …' and matched no
translation ('Prüfunging the package again …'); the label is an element
of its own now
- no error message of shareos-update, of the update part of the plugin and
of shareos-flash-bin was in the catalogue: 33 texts and 20 patterns added,
with all nine translations
- i18n.js: a value inside a pattern ($1 in 'Download: $1') is translated
when it is a text of its own (several words, known as a whole or as a
pattern), so the messages are translated behind a prefix too, and 'other
firmware' in the dialogs
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Sb3gb1FHs6DNkZHKinKAJv
test-storage failed on GitHub with 'mkswap: cannot open /dev/loop1p1: No such device or address' (run 44358572104): partition() waited for the node of the data partition only. Where the table is read again after sfdisk has closed the disk, a partition is removed and added back; its node is there, opening it fails. Wait until every new partition opens, and try mkswap again. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sb3gb1FHs6DNkZHKinKAJv
…183) ksmbd knows neither [homes] nor %H (Samba), so \\box\<account> was never found. write_smb writes one section per account with a personal folder: valid users = <account>, not browseable, masks 0600/0700. A share of the same name wins. Around it, from a look at everything that deals with the personal folders: - shares.set: a new share cannot take the name of an account with a personal folder; 'home', folders in it that are no account's and '.shareos' cannot be shared (home/<account> still can) - ensure_folder: nothing is made in 'home' but folders inside the personal folder of an account, and those belong to the account (0700), not to root:users 2775 - a share on a personal folder writes files with 0600/0700 - shareos-users: no personal folder for an account with the name of a share; a folder home/<name> of someone else is not taken over; the uid of a deleted account is not reused (accounts.ids.last_uid); home directory '/' when the personal folder is off Reported and analysed by Rambooka. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sb3gb1FHs6DNkZHKinKAJv
… off The folder is not moved: the old one stays, the account starts empty on the new drive, and what its apps keep there is missing. The dialog asks first and says so; switching it off likewise. An account whose drive is gone or not mounted shows 'drive not present'. Texts in all nine languages. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sb3gb1FHs6DNkZHKinKAJv
The run with the first fix got past mkswap and failed one step later: 'mdadm: cannot open /dev/loop2p2: No such device or address' (run 44374928238) – the first disk's partitions were gone again for a moment while the second one was partitioned. wait_parts before mdadm --create, mdadm --add and mkfs. test-storage prints the partitions, swaps and the udev state when a setup fails. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sb3gb1FHs6DNkZHKinKAJv
# Conflicts: # CHANGELOG.md
The new check expected /bin/false for jan, who is an admin (run 44389057767: 188 passed, this one failed). The home directory is what it is about. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sb3gb1FHs6DNkZHKinKAJv
The labels said 'STATUS LED (BLUE)' and 'DISK LEDS (RED)' on every model. The disk LEDs of the DNS-320 rev A/B and the DNR-322L are orange, the status LED of the DNS-325 is white and its USB LED red. hardware.led has the colours now, read from the LED names in /tmp/sys/board.env; the page picks the label by them. New texts in all nine languages. Found by Rambooka on a DNS-320 rev A1. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sb3gb1FHs6DNkZHKinKAJv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the test report for the DNS-320 rev A1 (#185, Rambooka): the LED settings call the disk LEDs "(RED)"; on that box they are orange.
Stacked on #184 (
CHANGELOG.md, numbers intools/i18n) – merge #182, #184, then this one.Cause
The labels were written for the DNS-320L:
STATUS LED (BLUE),DISK LEDS (RED), "The orange USB LED …". Byboard.sh:Fix
parts/rpc/system.uc:hardware.led.colours– status, usb, disks, taken from the LED names in/tmp/sys/board.env(dns320:orange:l_hdd→orange).parts/web/system-general.js: the label is picked by the colour; without a known colour it is justSTATUS LED/DISK LEDS, and the note about the USB LED is left out.tests/mock-ubus.pyhas the colours of the DNS-320L.tests/check-i18n.py,tests/check-i18n-coverage.jsandtests/static-analysis.shpass. Not tried on a box.Generated by Claude Code