Skip to content

App theme: the hidden attribute hides, whatever display a class gives - #188

Merged
UniqueDroid merged 2 commits into
mainfrom
fix/sdk-hidden
Nov 19, 2026
Merged

UniqueDroid merged 2 commits into
mainfrom
fix/sdk-hidden

Conversation

@UniqueDroid

Copy link
Copy Markdown
Owner

Found while reviewing ShareOS-Apps #57: the Transmission app hides its Revoke password button with the hidden attribute, but the button has the class sos-btn, which sets display: inline-flex. An author rule beats the browser's own [hidden] { display: none }, so the button stayed visible. Every app that uses an SDK class with a display together with hidden runs into this.

Stacked on #187 (CHANGELOG.md) – merge #187, release 0.3.0-beta.14, then this one. It opens the section ## 0.3.0-beta.15.

Fix

/_shareos/theme.css: [hidden] { display: none !important; }

Checked in Chromium with the SDK's theme.css: a .sos-btn with hidden computes to display: flex without the rule and to none with it. tests/test-apps.sh checks that the served theme.css has the rule.

Apps keep working on older firmware; they only need the line in their own CSS until their users have this version.


Generated by Claude Code

README: personal folders over SMB, NFS on personal folders, the app SDK
additions, the DNS-320 rev A1 has a first test report (#185). Timeline
for 17.–19.11. in both languages. CHANGELOG: the LED line no longer names
the DNR-322L, which is not in this release.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Sb3gb1FHs6DNkZHKinKAJv
.sos-btn sets display: inline-flex, and an author rule beats the browser's
own [hidden] rule: a .sos-btn with hidden stayed visible (Transmission's
revoke button, ShareOS-Apps #57). Checked in Chromium: display 'flex'
before, 'none' with the rule. test-apps checks the rule is served.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Sb3gb1FHs6DNkZHKinKAJv
@UniqueDroid
UniqueDroid marked this pull request as ready for review November 19, 2026 18:05
@UniqueDroid
UniqueDroid merged commit 6ba26fc into main Nov 19, 2026
7 checks passed
@UniqueDroid
UniqueDroid deleted the fix/sdk-hidden branch November 19, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants