Repository navigation
App theme: the hidden attribute hides, whatever display a class gives - #188
Merged
Merged
Conversation
README: personal folders over SMB, NFS on personal folders, the app SDK additions, the DNS-320 rev A1 has a first test report (#185). Timeline for 17.–19.11. in both languages. CHANGELOG: the LED line no longer names the DNR-322L, which is not in this release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sb3gb1FHs6DNkZHKinKAJv
.sos-btn sets display: inline-flex, and an author rule beats the browser's own [hidden] rule: a .sos-btn with hidden stayed visible (Transmission's revoke button, ShareOS-Apps #57). Checked in Chromium: display 'flex' before, 'none' with the rule. test-apps checks the rule is served. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sb3gb1FHs6DNkZHKinKAJv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while reviewing ShareOS-Apps #57: the Transmission app hides its Revoke password button with the
hiddenattribute, but the button has the classsos-btn, which setsdisplay: inline-flex. An author rule beats the browser's own[hidden] { display: none }, so the button stayed visible. Every app that uses an SDK class with adisplaytogether withhiddenruns into this.Stacked on #187 (
CHANGELOG.md) – merge #187, release 0.3.0-beta.14, then this one. It opens the section## 0.3.0-beta.15.Fix
/_shareos/theme.css:[hidden] { display: none !important; }Checked in Chromium with the SDK's
theme.css: a.sos-btnwithhiddencomputes todisplay: flexwithout the rule and tononewith it.tests/test-apps.shchecks that the servedtheme.csshas the rule.Apps keep working on older firmware; they only need the line in their own CSS until their users have this version.
Generated by Claude Code