Repository navigation
Header: who is signed in, next to the clock (#191) - #192
Merged
Merged
Conversation
The admin view showed nowhere which account is signed in. A small field with a person icon and the name sits left of the clock; on narrow screens it moves along with the clock. The name is never translated; 'Signed in' (title and for screen readers) in all nine languages. The view for users without admin rights already had the name in its info line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sb3gb1FHs6DNkZHKinKAJv
# Conflicts: # CHANGELOG.md # src/shareos-core/www/i18n/ar.json # src/shareos-core/www/i18n/bn.json # src/shareos-core/www/i18n/de.json # src/shareos-core/www/i18n/es.json # src/shareos-core/www/i18n/fr.json # src/shareos-core/www/i18n/hi.json # src/shareos-core/www/i18n/pt.json # src/shareos-core/www/i18n/ru.json # src/shareos-core/www/i18n/zh.json # tools/i18n/ar.tsv # tools/i18n/bn.tsv # tools/i18n/catalog.json # tools/i18n/de.tsv # tools/i18n/es.tsv # tools/i18n/fr.tsv # tools/i18n/hi.tsv # tools/i18n/pt.tsv # tools/i18n/ru.tsv # tools/i18n/zh.tsv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #191 (Rambooka): the web interface showed nowhere which account is signed in.
Change
The admin header gets a small field left of the clock: a person icon and the account name. On narrow screens it moves left with the clock. Jan picked this place from two mock-ups (next to the clock, or in the info line with host, model, version and address).
parts/web/layout.js:.clocklineholds the name and the clock; the name hasdata-i18n-skip, so an account called "Admin" or "Media" is never translated.www/shareos.css:.clockline,.who.Checked in Chromium against
tests/mock-ubus.py, 1440 px and 600 px wide. Not tried on a box.tests/check-i18n.py,tests/check-i18n-coverage.jsandtests/static-analysis.shpass.CHANGELOG.md(0.3.0-beta.15) is touched by #181 and #189 as well – whichever is merged later getsmainmerged in.Generated by Claude Code