Skip to content

Enable every ty rule #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamtheturtle merged 1 commit into from
Sep 22, 2026
Merged

Enable every ty rule #3673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions admin/create_secrets_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,11 +290,8 @@ def main() -> None:
for i in range(num_databases)
]
files_to_create = [file for file in required_files if not file.exists()]
driver: WebDriver | None = None

while bool(files_to_create):
if driver is None:
driver = vws_web_tools.create_chrome_driver()
driver = vws_web_tools.create_chrome_driver()
file = files_to_create[-1]
_ = sys.stdout.write(f"Creating database {file.name}\n")
(
Expand Down Expand Up @@ -327,11 +324,9 @@ def main() -> None:
except TimeoutException:
_ = sys.stderr.write("Timed out during database setup\n")
driver.quit()
driver = None
continue

driver.quit()
driver = None

file_contents = _generate_secrets_file_content(
cloud_database_details=cloud_database_details,
Expand Down
12 changes: 1 addition & 11 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,17 +468,7 @@ enableTypeIgnoreComments = false
reportUnnecessaryTypeIgnoreComment = true

[tool.ty]
rules.blanket-ignore-comment = "error"
rules.division-by-zero = "warn"
rules.dynamic-function-decorator-return = "error"
rules.missing-type-argument = "error"
rules.possibly-missing-attribute = "warn"
rules.possibly-missing-import = "warn"
rules.possibly-unresolved-reference = "warn"
rules.unsound-assignment = "error"
rules.unsound-return-statement = "error"
rules.unsound-yield = "error"
rules.unsupported-dynamic-base = "warn"
rules.all = "error"
terminal.error-on-warning = true
analysis.respect-type-ignore-comments = false
analysis.strict-equality-semantics = true
Expand Down
Loading