ci: type-check tests/ and send a User-Agent on sim API requests

[scott-lowe-vapi]

Value

V.A.L.U.E. tier: project — PR 1 of 10 for inline simulation PR checks (TEST-141); this PR is a small, behavior-preserving slice.

• Problem: tests/ was never type-checked (tsconfig.json included only src/), so 37 type errors piled up silently. That's the gap test: restore the suite after the hash-store migration and run it in CI #56 named as follow-up in improvements.md fix(push,pull): recanonicalize stale UUID-suffixed state keys — root-cause duplicate generation #32. Separately, simulation runs started from gitops can't be told apart in the platform's analytics.
• Who it affects: gitops maintainers and contributors, who get a compiler check on test fixtures; and the TEST-141 success measure, which needs a pre-release baseline of gitops-started runs.
• What changes:
  • npm run build, which CI already runs on every PR, now type-checks tests/.
  • The 37 errors are fixed.
  • npm run sim sends User-Agent: vapi-gitops-sim/<version>. The API records this as user_agent on the [simulation] run started event.

The CI workflow itself landed in #56, so this PR is smaller than PR 1 in the plan.

Evidence of value

Check	main (69c7e83)	This branch
tsc --noEmit with tests/ included	37 errors (6 test files)	0 errors
npm test	355 pass	357 pass (2 new, 1 rewritten)
User-Agent on POST /eval/simulation/run	none	vapi-gitops-sim/1.0.0 (asserted against a local HTTP server)

What the 37 errors were:

• Fixture drift after the hash-store migration: state entries still carrying lastPulledHash/lastPushedHash, bare-string state values, and an untyped emptyLoaded().
• One real gap: the reconcile-state-key harness never passed the required formatError, so any test reaching that error path would have thrown a TypeError instead of testing it.

Tests that used the removed hash fields as markers (state-merge, recanonicalize) now mark "which copy won" with distinct UUIDs or object identity, so they still check the same behavior.

Testing plan

• npm run build (now covers src/ and tests/) and npm test locally on Node 22: green. CI on this PR runs both on Node 20 and 22.
• New tests/user-agent.test.ts covers the header format against package.json's version, and the header actually sent on run create.
• sim.test.ts now covers the legacy bare-string state value directly, replacing the old cast-based "forward-compat" test.
• Not tested: a live run against the API (the header is asserted locally only), and Node 20 locally (left to CI). src/ behavior is unchanged apart from the added header.

Refs TEST-141

🤖 Generated with Claude Code

[scott-lowe-vapi]

• feat(promotion): gate promotion out of an org on a passing check #66
• feat(check): add the opt-in Vapi checks PR workflow and user docs #64
• feat(check): run checks live and report Vapi Evals statuses #63
• feat(check): fail closed on tools and servers in inline check payloads #62
• feat(check): build inline simulation-run payloads and add a dry-run CLI #61
• feat(check): parse vapi-checks.yml check configuration #60
• refactor: move resource parsing and org connection helpers into config-free modules #59
• fix(sim): report failed, canceled and incomplete runs instead of a false pass #58
• ci: type-check tests/ and send a User-Agent on sim API requests #57 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.