Repository navigation
fix(calls):: Put back the native call playback buffer target (PLAY_AHEAD_MS) to 60ms to fix audio crackling - #101
Merged
Conversation
…EAD_MS) to 60ms to fix audio crackling. This gives the audio thread more headroom against scheduling delays and output callback bursts, and reduces buffer underruns, which otherwise insert silence into the audio stream and can produce audible crackling, at the cost of approximately 30 ms of additional playback latency. Root cause analysis: The native playback buffer could run out of decoded audio before the output callback needed its next samples, causing the mixer to insert silence. These repeated underruns created audible crackling; increasing the buffer gives playback more headroom to absorb scheduling delays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives the audio thread more headroom against scheduling delays and output callback bursts, and reduces buffer underruns, which otherwise insert silence into the audio stream and can produce audible crackling, at the cost of approximately 30 ms of additional playback latency.
Root cause analysis: The native playback buffer could run out of decoded audio before the output callback needed its next samples, causing the mixer to insert silence. These repeated underruns created audible crackling; increasing the buffer gives playback more headroom to absorb scheduling delays.
Video illustrating the problem on Ubuntu Desktop:
https://github.com/user-attachments/assets/06ef9556-3b37-4c2e-b705-676d27e30e8c
Video illustrating the fix:
https://github.com/user-attachments/assets/cdeed9e8-df51-4efd-9b3c-2975756bf250