Skip to content

Added exported INDRA evidence-source lists - #131

Merged
tonywu1999 merged 1 commit into
develfrom
MSstatsBioNet/work/20261009_phase5b-evidence-sources
Oct 9, 2026
Merged

tonywu1999 merged 1 commit into
develfrom
MSstatsBioNet/work/20261009_phase5b-evidence-sources

Conversation

@tonywu1999

Copy link
Copy Markdown
Contributor

Summary

  • Exported INDRA_DATABASE_SOURCES (22 curated databases) and INDRA_TEXT_MINED_SOURCES (11 text-mining systems), documented on ?indra_evidence_sources. get_network(indra, entities, evidence_sources = INDRA_DATABASE_SOURCES) keeps only edges with curated-database evidence.
  • The lists use INDRA's internal names (psp, pc, pe, vhn, bel_lc), from db_sources / reader_sources in indra.util.statement_presentation (INDRA 1.23.0), the module INDRA CoGEx uses. These are the keys CoGEx returns in source_counts; the SOURCE_INFO names (phosphosite, biopax, ...) never appear there, so filtering on them would silently drop PhosphoSitePlus and Pathway Commons evidence.
  • backend_capabilities(indra_backend())$evidence_sources returns list(database =, text_mined =).
  • A source name in neither list warns rather than errors (INDRA adds sources between releases), suggesting the internal name where there is one, e.g. Use "psp" for "phosphosite". This also applies to getSubnetworkFromIndra(sources_filter =).
  • expect_backend_contract() checks the shape of evidence_sources when a backend reports it.

Phase 5b of the API refactor. No new dependencies.

Test plan

  • devtools::test(): 1082 pass, 0 fail
  • devtools::check(): 0 errors, 0 warnings, 1 pre-existing NOTE (MSstats in Depends not imported)
  • New tests: the lists don't overlap and cover every source in indraResponse.rds; capabilities; filtering by each list; warning with the alias hint and for an unknown name
  • Live CoGEx query (1926 statements): every source_counts key is in the two lists
  • ?indra_evidence_sources example against live INDRA: 31 edges, 16 with database evidence, 19 with text-mined evidence

Co-Authored-By: Claude noreply@anthropic.com

* INDRA_DATABASE_SOURCES and INDRA_TEXT_MINED_SOURCES, with INDRA's
  internal names, for get_network(evidence_sources =)
* backend_capabilities() lists them under evidence_sources
* Unknown source names warn, suggesting the internal name if there is one
* Tests for the lists, the filters, and the warning

Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 18 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 94473116-6b00-481b-8c8f-f05eb47a0653

📥 Commits

Reviewing files that changed from the base of the PR and between 619c4fc and c212f46.


📒 Files selected for processing (11)
  • NAMESPACE
  • NEWS.md
  • R/AllGenerics.R
  • R/backend-indra.R
  • R/getSubnetworkFromIndra.R
  • man/backend_capabilities.Rd
  • man/getSubnetworkFromIndra.Rd
  • man/get_network.Rd
  • man/indra_evidence_sources.Rd
  • tests/testthat/helper-contract.R
  • tests/testthat/test-backend-indra.R


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.07%. Comparing base (619c4fc) to head (c212f46).

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #131      +/-   ##
==========================================
+ Coverage   86.97%   87.07%   +0.09%     
==========================================
  Files          24       24              
  Lines        2757     2778      +21     
==========================================
+ Hits         2398     2419      +21     
  Misses        359      359              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tonywu1999
tonywu1999 merged commit a05d90d into devel Oct 9, 2026
4 checks passed
@tonywu1999
tonywu1999 deleted the MSstatsBioNet/work/20261009_phase5b-evidence-sources branch October 9, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants