[NFC] Use RPOQueue in liveness-traversal - #9152
Merged
Merged
Conversation
tlively
approved these changes
Sep 24, 2026
| // By processing blocks with higher RPO indexes first, we process successors | ||
| // before predecessors, and fully process loops and diamonds before flowing data | ||
| // backwards to earlier blocks in the CFG. | ||
| template<typename CFG> using POQueue = RPOQueue<CFG, std::less<Index>>; |
Member
There was a problem hiding this comment.
I can't not read this as "program-order queue," which is exactly wrong 😢
Member
Author
There was a problem hiding this comment.
We could write this out as PostOrderQueue, though ReversePostOrderQueue is clunky...
Another option is RRPOQueue 😉
Member
There was a problem hiding this comment.
Yeah, it's ok as-is. I'll just have to deal with it.
Member
Author
There was a problem hiding this comment.
Ok, landing for now, but I'm happy to rename later to PostOrderQueue if you find this annoying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes CoalesceLocals 15% faster, for similar reasons as #9149.
Helps #4165