Repository navigation
test(client): stop the renewal-spread test timing out - #101
Merged
Merged
Conversation
It advanced fake time one second at a time from zero, about 3,300 async timer flushes per tab. That ran 4s locally and timed out at Jest's 5s on CI. Jump to 1500s first (no spread renews before 1620s), assert nothing renewed early, then step. 0.4s now; still fails when both tabs use the same spread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'two pages with different spreads' test stepped fake time 1s at a time from zero (~3,300 async flushes per tab): 4s locally, and it timed out at Jest's 5s default on CI. It now jumps to 1500s (no spread can renew before 1620s), asserts nothing renewed early, then steps. Runs in 0.4s and still fails if both tabs use the same spread.