Skip to content

test(adapters): isolate honeytoken suites from ingest - #99

Merged
cport1 merged 1 commit into
mainfrom
fix/adapter-tests-offline
Nov 16, 2026
Merged

cport1 merged 1 commit into
mainfrom
fix/adapter-tests-offline

Conversation

@cport1

@cport1 cport1 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

What failed

After #98 fixed the Hono timeout, the post-merge main workflow exposed the same isolation bug in Express. The honeytoken adapter suites used dummy API keys with skipLocalAnalysis: true, so they called production ingest and could consume Jest's full five-second timeout.

Fix

  • stub the expected detector call in the Express and Fastify honeytoken suites
  • preserve Express's real loopback requests while rejecting any unexpected external URL
  • restore global fetch after every test
  • keep production timeouts unchanged

Validation

  • Express: 15/15 tests pass in ~1.1 seconds
  • Fastify: 11/11 tests pass in ~0.5 seconds
  • Hono: 12/12 tests pass in ~0.7 seconds
  • builds pass for node, Express, Fastify, and Hono
  • adapter lint passes; Express retains its 10 pre-existing allowed warnings
  • git diff --check

Follow-up to #98 and the failed post-merge run https://github.com/WebDecoy/node/actions/runs/43923274529.

@cport1
cport1 merged commit 1d372a8 into main Nov 16, 2026
2 checks passed
@cport1
cport1 deleted the fix/adapter-tests-offline branch November 16, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant