Repository navigation
Keep inputs safe during runs, and show what runs do in the editor - #99
Merged
Merged
Conversation
No test held the runner to its output concurrency limit, and the dispatch loop is about to be rewritten to claim destinations before it waits for a slot. The test makes every delivery wait until the cap is in flight, so it fails both when deliveries exceed the cap and when they never overlap. Co-Authored-By: Rooty
Each visual test class carried its own copy of the station lookup, the click and centre helpers, the inspector-ready check and the template load, and one copy had already lost the guard against an empty inspector. One copy on the session keeps them from drifting and lets the next tests and any change to the template command touch one place. Co-Authored-By: Rooty
The eight icon-only toolbar buttons had no accessible name, so their automation peers reported the icon's type name or "?"; a tooltip is only help text. Each now carries the action its tooltip names. The log strip's counts, current file and summary and the empty-state overlay get automation ids, so UI tests find them by id instead of by layout or displayed text. Co-Authored-By: Rooty
Files from older versions now load with notices naming each behaviour change, a future version is refused instead of misread, and the CLI will not silently run a pipeline whose meaning changed. Saving always writes the current version, so re-saving is how a file accepts the changes. Co-Authored-By: Rooty
The base theme painted IGNITE's presenter in its own blue accent, so the molten gradient only showed on hover and the pressed state reused the hover brush. Part rules now name the forge brush for every state, and the base theme's Dark palette takes the forge orange so checked boxes and other accent-drawn controls stop showing blue. Co-Authored-By: Rooty
Destinations must be decided in input order before concurrent delivery starts, so outputs now claim each destination in the serial dispatch loop and deliver to what they claimed. Nodes also need run-scoped state that a boolean dry-run flag cannot carry. Co-Authored-By: Rooty
The body font named the family alone, which only searches installed system fonts, so text fell back to whatever the system offered. The bundled copy is registered under its own source, and naming that source makes body text render in the font the app ships. Co-Authored-By: Rooty
The status paragraph promised that the app lists changed settings before the first run, which it does not do yet. Keep the part that is true today: older files open, and the CLI refuses one whose settings changed until it is re-saved. Co-Authored-By: Rooty
A text block clips to its bounds by default, and with the line height set to the font size the box is shorter than the glyphs, so the wordmark, the empty canvas headline and the station titles lost the tops and tails of their letters. A tight class lets them draw past the box without changing layout, and a scan keeps every such site on it. Co-Authored-By: Rooty
Two jobs aimed at one output name used to fail or clobber each other depending on 'overwrite'. Claims now go through one registry for the whole run: a run never replaces its own output (the later file gets a _1, _2 suffix), and an existing file is replaced only when asked. Older pipeline files say so in a load notice. Co-Authored-By: Rooty
The DRY RUN half-disc and IGNITE's play mark had no glyph in the font they were set in, and the log rows and shortcut keys named fonts that only some systems install, so each fell back to whatever font the machine had. Every text now resolves to a font the app ships, and the half-disc is drawn as an icon. A live-tree walk checks each character against its resolved font, and a source scan rejects literal names. Co-Authored-By: Rooty
Transforms renamed, re-encoded and deleted files under the input folder, so a run could destroy the very files it was asked to process. Now they read the original, write private staged copies under the system temp folder, and only outputs write to user folders; a move deletes an original only after every delivery of it is in place. Co-Authored-By: Rooty
A running station's heat pulse lights the body behind its subtitle to nearly the subtitle's own colour (contrast about 1.0 to 1.7). Bone text alone still measured 2.3 to 4.3 over the brighter glows, so the subtitle also gets a dark plate while running; the plate's margin cancels its padding, so nothing moves. Co-Authored-By: Rooty
The station template had no hover state, so nothing marked the station a click or drag would take. One pointer-over rule on the station root now lifts it a pixel and drops it back when the pointer leaves. Co-Authored-By: Rooty
The gauges, HUD, process id and SRC slot showed fixed text whatever ran, and the console count summed every terminal, which can pass the total. Count and bar now read originals whose last branch ended; slots nothing measures show a dash. Tests rewritten to the new count: ProgressText_ReturnsCorrectPluralization (now ..._reads_finished_originals_over_total), ReportProgress_CalculatesProgressPercentage (now Progress_counts_finished_originals_only). Co-Authored-By: Rooty
DEMO animates every station and pipe without a run, but the console still read COLD with an idle caption and a process id slot, so nothing on screen said the motion was a demo. The console now reads DEMO with a caption saying no files are touched, and hides the process id, count and throughput that only a real run has. Co-Authored-By: Rooty
Every transform takes all its files before the next starts, and a file passing through one reports nothing, so progress sat at zero through the slow resize and convert steps and then filled in a burst at the output. Each step now reports how many of its inputs it has taken, at its start, every 25 jobs and at its end; the log's phase label names the step. The progress count stays on finished originals. Co-Authored-By: Rooty
Staged copies of the user's files need a folder no other local user can create first or redirect. On Linux and macOS a shared temp folder cannot be made safe without knowing who owns a folder in it, so staged copies now go to the user's own data folder, created private; a run refuses to stage when the user has none, and still refuses a folder other users can write. Windows keeps its per-user temp folder unchanged. Co-Authored-By: Rooty
Rename and image nodes now work on private copies, so the warning to point the input at a copy of your files is no longer true. Folder Output's mode description, the README, the user guide and the samples README say what a run now does, and the docs check requires that claim instead of the warning. Co-Authored-By: Rooty
A format override wrote WebP or JPEG bytes under the old extension, so it had to be refused. The output name now follows the bytes, so the override is safe to offer again; Image Convert takes its extensions from the same map. Co-Authored-By: Rooty
An unwritable extension failed only after a full decode, and the dry run reported success for it and for oversized files. Both checks now run first, from configuration and a file size, so a dry run reports the refusal a live run would; Image Convert and Image Compress also name the size limit in the file's error instead of only in its log. Co-Authored-By: Rooty
The strip under the log tabs repeated the console's file count beside an always-moving bar, so a run showed two progress bars, and its label counted every finished branch rather than every finished file. The strip now shows the phase label alone, counted on the same finished originals as the console's bar, and the unused phase property is gone. Co-Authored-By: Rooty
Since the flush timer went, every processed file was flushed the moment it was buffered, so the buffer never held more than one job and its batch loop, per-status deltas and flush on each phase change did nothing. Each file now updates the log and its counter directly. Co-Authored-By: Rooty
Each row already carried the time it was logged and the lines every node wrote for its file, but the rows showed neither, so a failed or skipped file gave no clue which step touched it last. Rows on all three tabs now lead with the time and show the node log as their tooltip. Co-Authored-By: Rooty
The dry run used size 0 and default dates, so Filter dropped files the real run keeps and Sort ordered them differently; its preview disagreed with the real run. It now reads sizes and dates, never file content, marks each preview it cannot vouch for, and the CLI's dry-run summary prints how many jobs are marked. Co-Authored-By: Rooty
Each log list laid its rows out in a plain stack panel, so it built a full row of controls for every entry it held, up to 5,000 per list, on the UI thread, and kept them until the next run. A virtualising panel builds only the rows in view. Co-Authored-By: Rooty
Dropped and failed files are reported before any output, so they filled the Output tab ahead of every produced file and could use up its 5,000-row cap before one appeared. Each status now has its own list. The Warnings tab becomes Skipped, the word the summary and rows use; the guide and changelog follow, and a check ties the guide's tab bullets to the tab headers. Co-Authored-By: Rooty
A dry run marks a job unresolved when it claims in a folder where an unresolved preview claimed first, since that file's real name, and so every suffix after it, is unknown. Nothing tested it. The preview comparison now also needs a compared job in every pipeline that does not name files by metadata, so a change marking every job unresolved can no longer pass it with nothing compared. Co-Authored-By: Rooty
With every fixture locked against reads, each sample, template and an all-node chain dry-runs cleanly, and an image dry run reports the same size and format refusals as a real run, so the documented dry-run promise is now tested and the docs can state it in full. Co-Authored-By: Rooty
Both changes alter what an existing pipeline does: the CLI now refuses older files until they are re-saved, and two files bound for one name no longer fail or replace each other. The changelog said neither. Co-Authored-By: Rooty
The editor accepted a pipe from a station back to one that already feeds it, and the run then refused the whole pipeline. The drop is now refused like a duplicate or same-direction one: no pipe, no undo step. Co-Authored-By: Rooty
An emptied number box was refused as unparseable, so its old number stayed in the pipeline; it now removes the key, and redoing that clear removes it again instead of storing an empty element. Typing coalesced by dropping the previous keystroke's command, so one undo restored only the text before the last key. A merged entry now keeps the first edit's old value, and an edit after a save starts a new entry so undo still returns to the saved pipeline. Co-Authored-By: Rooty
Undoing a delete put the station back with its selected flag set, but the flag changed while the editor was not listening to that station, so the inspector stayed empty. The node-add handler now selects a station that arrives selected, which covers every re-add path. Co-Authored-By: Rooty
The inspector's browse buttons opened the platform pickers from the view, outside the dialog service every other file dialog uses, so no test could drive them. Each path field now has a browse command that asks the dialog service and stores the chosen path through its value, one undoable change; a closed dialog changes nothing. The picker code in the view is gone. Co-Authored-By: Rooty
The browse buttons went through the dialog service without the catch their old picker code had, so a dialog that could not be shown ended the app; Open, Save and Save As always did. One catch around the three pickers logs the failure and reads it as a closed dialog. Co-Authored-By: Rooty
The guide lists disconnect as an undoable action, but nothing was bound to the editor's disconnect gesture, so a pipe could only go with a deleted station. The editor-level command removes every pipe on the port as one step, so one Undo restores them all. Port-click NRE repro outcome: a plain click on a connected port did not throw on a virtual display or on a real Windows window; no guard. Co-Authored-By: Rooty
The help dialog listed Space+drag and Ctrl+scroll, which do nothing, and zoom ran from 10% to 200%. It now lists the gestures the editor answers (middle/right-drag, scroll, Alt+click on a port), zoom stays within 25-400%, and one test drives every listed row against the live window. The guide's shortcut list is checked against the dialog row by row. Co-Authored-By: Rooty
The gesture hint at the canvas's top left showed through the empty state, behind its ready line. It names gestures on stations, so it now shows only once there are stations, like the system readout beside it. Co-Authored-By: Rooty
Stations keep their fixed width, so seven of eleven titles and most subtitles end in an ellipsis and there was no way to read them. Both now carry their full text as a tooltip. Co-Authored-By: Rooty
In the narrowest window the hint caption above the stations needs about 343 px and the canvas pane leaves it 320, so the pane edge cut its last words off. It now wraps clear of the corner mark and stays on one line wherever the pane has room. Co-Authored-By: Rooty
A number field that refuses its text is outlined in the error colour, and that rule must come after the focus rule or the outline vanishes while the user is still typing. No test rendered it, so moving or dropping the rule went unnoticed; the new check reads the border's pixels with the field focused and unfocused. Co-Authored-By: Rooty
The key was exposed for coalescing typed edits, but merging now goes through the command itself and nothing in the app reads the property; only a test asserting its value kept it alive. The removed-members scan keeps it from coming back unnoticed. Co-Authored-By: Rooty
Each member the editor gained to show or drive a state (the Save As and disconnect commands, the dirty flag, run readings, undo state, log row fields, the folder picker) must be read by a view binding or by code, or it is dead weight that only its tests keep alive. Declarations, writes, comments and plain string text are not counted, so a log template naming a field cannot stand in for the view that shows it. Co-Authored-By: Rooty
Co-Authored-By: Rooty
Files now travel along connections, so one step may feed two outputs and the fan-out graph these tests relied on runs to completion. A branch that reaches no output is still refused: the editor keeps it, and the graph checks name each of its steps on its own line. Co-Authored-By: Rooty
With the output folder equal to or inside the input folder and overwrite on, one file can be delivered onto another file's original. Move mode decided each delete from that original's own deliveries, so it deleted the path the other file had just been delivered to, and every file reported success. Every destination is now claimed before the first delivery, and a moved original that any claim of the run names, resolved through links, is kept. Co-Authored-By: Rooty
With overwrite on and the output inside the input, one file's delivery can replace another input before that input's own delivery reads it, so copy mode delivered the replaced bytes and a renumber in place lost a file. Inputs that a claim of another job overwrites are now copied into the run's staging folder before the first delivery. If the copy fails, the job that would overwrite the input fails instead; a dry run logs the copy it would make. Co-Authored-By: Rooty
Claims resolve their targets when they are made, but the moved original was resolved only at completion. A linked input or output folder pointed elsewhere in between made the lookup miss, and the delete then reached a file the run never read. Each original now keeps its resolution from discovery; a path that resolves elsewhere at completion is kept. Co-Authored-By: Rooty
An extra job was counted only after the transform returned, so an extra given its own staged content let go of the input's staged file on its behalf first: the input's delivery then failed on a missing file. Extras are now made by RunContext.Branch, which counts them when they are created, and the run stops on an extra made any other way. Co-Authored-By: Rooty
A number field parsed each keystroke without the user's thousands separator, so typing 1,920 stored 1 and the run resized every image to 1 px wide; the only sign was an outline colour. The field now reads the current culture's separators, and text it still refuses is explained under the box, naming the number the pipeline keeps. Co-Authored-By: Rooty
Since names that collide get a suffix when claimed, the claimed name reached the job only after a live delivery. A dry run of two files renamed to one name listed that name twice, which reads as one file overwriting the other; the live run writes both, one with a suffix. Co-Authored-By: Rooty
--format json wrote every job property, including the internal content path. For a transformed file it named a staged copy already deleted when the JSON is printed, and for a moved file the deleted original, and a consumer could not tell it from currentPath. Co-Authored-By: Rooty
Three docs and the changelog said rename and image nodes work on private copies. Rename nodes copy nothing, and image nodes write into a per-run folder that holds every rewritten image until delivery starts; no doc named that folder, its space need or when it is emptied. Co-Authored-By: Rooty
Dry runs now read real sizes and dates in Filter and Sort, refuse what the image nodes refuse, list suffixed names and print a count of files whose preview may still differ, but no changelog entry said so, the 1.4.1 entry still claimed the old behaviour and the guide never named the new summary line. Co-Authored-By: Rooty
The app has always shipped Inter inside the Avalonia.Fonts.Inter package, and body text now renders in it, but the notices said three font families, called Inter not redistributed, and the font licence file carried no copyright line for it. Co-Authored-By: Rooty
"Copy leaves the input files unchanged" was false for a run that delivers into its own input folder with overwrite on, where a delivered file replaces another input by design. The docs, the mode description and the changelog now say so, and the guide explains the copy-aside step, its dry-run line and the number-field message, with checks that quote both strings as the code writes them. Co-Authored-By: Rooty
Ctrl+Shift+Z redoes like Ctrl+Y, but the shortcuts window and the user guide listed only Ctrl+Y. A new check sends every key under every modifier set to the main window and fails on any gesture it handles that the window does not list, so a shortcut added later cannot go unlisted. Co-Authored-By: Rooty
Headless text renders with subpixel antialiasing on Windows and with greyscale on Linux, and the check averaged every glyph pixel, edges included, so it measured the antialiasing: the same palette read 3.4 to 3.7 on Windows and 6.3 to 6.8 on Linux. Each glyph pixel blends the text colour with the body behind it, so the quarter farthest from that body still bounds the text's contrast from below and reads the colours under either mode. Co-Authored-By: Rooty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
movedeletes an input only after every delivery of it succeeded, and never deletes a file that another delivery of the run lands on.overwriteon is still supported. An input that another delivery overwrites is first copied aside, so every input is read as it was when the run started._1,_2… suffix.Notes