Skip to content

fix(meetings): build on cli-core 0.663.0 and cli-base 0.100.0 - #26

Merged
leemour merged 1 commit into
mainfrom
fix/review-followups
Nov 14, 2026
Merged

leemour merged 1 commit into
mainfrom
fix/review-followups

Conversation

@leemour

@leemour leemour commented Nov 14, 2026

Copy link
Copy Markdown
Member

Why

cli-core 0.663.0 (WireCatLabs/cli-core#2953) needs hosts to pass pagingOf to addMeetingCommands; pbx was still on 0.656.0 and did not build. The jump also brings 0.660.0's read-through meetings list/show, which broke two things in pbx.

What

  • Pin @wirecat/cli-core 0.663.0 and @wirecat/cli-base 0.100.0; pass pagingOf.
  • meetings list example: --limit 50 (20 is now the default).
  • meetings show --json answered item.item: core answers { item, missing, meta } and pbx unwrapped only { item }. Fixed, with a regression test.
  • meetings list/show failed for a profile with no cdr_csv_path (core reads deps.source eagerly since 0.660.0, and pbx built the source from settings on creation). The source now reads its settings on the first fetch. Regression test.
  • A test holds that a bare meetings list pages by the configured defaults.limit.
  • Regenerated docs/commands.md, docs/dev/test-matrix.md (--backend rows marked untested with core's test as reason), contracts/wirecat.json.
  • lint/overrides.json: the undeclared-host github.com override was reported stale by cli-dev lint after the bump; removed.
  • Changelog fragment changes/fix-review-followups.md.

Testing

pnpm typecheck, pnpm lint, vitest run --maxWorkers=1 (16 files, 155 tests), test matrix check, pnpm docs:check, pnpm contracts:check, pnpm lint:commands, pnpm generate:check, pnpm standards:check.

🤖 Generated with Claude Code

cli-core 0.663.0 (was 0.656.0) makes the shared meetings commands page by
the profile's defaults.limit, so addMeetingCommands now takes pagingOf next
to budgetOf. The meetings list example passes --limit 50, not the new
default.

Since 0.660.0 meetings list and show read deps.source eagerly and answer
{ item, missing, meta }. pbx built its call source from the profile's
settings on creation, so a profile with no cdr_csv_path could no longer list
its store; the source now reads them on the first fetch. pbx's bodyOf
unwrapped show only when item was the sole key, so --json printed
item.item; it now passes core's item through with missing and meta.

The meetings and events commands drop their own --json/--jsonl for the
program's, and list and show gain --backend: the test matrix, the command
reference and contracts/wirecat.json are regenerated. cli-base 0.100.0 no
longer flags printed links as undeclared hosts, so the github.com override
is stale and goes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​wirecat/​cli-base@​0.98.0 ⏵ 0.100.099 +1100100 +196 +170
Updated@​wirecat/​cli-core@​0.656.0 ⏵ 0.663.098100100 +19670

View full report

@leemour
leemour merged commit 07bed09 into main Nov 14, 2026
16 checks passed
@leemour leemour mentioned this pull request Nov 14, 2026
leemour added a commit that referenced this pull request Nov 14, 2026
* chore(release): 0.5.0

Collects the two changes/ fragments into ## 0.5.0 — 14.11.2026 and raises the version: who said each line, Master.csv of any size (#25), cli-core 0.663.0 and cli-base 0.100.0 (#26).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* chore(release): live check of 0.5.0 passed

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@leemour
leemour deleted the fix/review-followups branch November 14, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant