Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
Author
|
Superseded by #805: all eight repositories were transferred at once, so this line now goes in with the main GitHub pass. |
leemour
added a commit
that referenced
this pull request
Nov 11, 2026
…y leaves (#2848) ## Why `memo people unlink` took a colleague's mailbox off the colleague instead of off the owner, because it never asked which person the identities leave (BUG-709). cli-core #2841 added the "from whom" check to the store, and memo #806 makes `--from` required. tg, max and wa `contacts unlink` still took an identity off whoever held it. The owner approved the same check there (NEED-2525 A), with `--from` required. ## What - `contacts unlink <person> --from person:<uid>|person:me` (and `services.people.unlink(person, { by, from })`). Without `--from` it is refused with `validation_error`, reason `person.from-required`. The message names who holds the identity and gives the command to run with their `--from`. An identity on someone else is refused with `identity.held-elsewhere`, and nothing moves. - cli-base 0.96.0, whose vocabulary has `--from <person>` (cli-base #563, NEED-2530 A). `bot search messages --from` now shows `<person>`, and its `option-role` baseline entry goes. - `parity.json` lists `--from` for `contacts unlink`; `docs/dev/STANDARD.md` is regenerated. - mongoose 9.12.1 in `bench/stemming/pnpm-lock.yaml` only, for Dependabot alert 29 (SEC-183, NEED-2527 A). - The changelog entry is under "Changed — may break callers". tg, max and wa need their docs regenerated at their next cli-core bump. ## Testing - Full `vitest run` on cli-base 0.96.0 (11179 passed, 16 skipped). This includes #562's refusal of the owner's real home. - `ci:quick`, `lint`, `docs:check`, and the command lint (0 new violations). - New tests: the service refuses without `--from` and names the holder and the command; it refuses a wrong `--from` and `person:me` when the identity sits elsewhere. The CLI test reads the `--from` out of the refusal and unlinks with it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WireCatLabs migration, Phase 2: the cross-repository line(s), split from the GitHub-pass PR so that PR can merge on its own.
Merge right after leemour/cli-core is transferred — it is red until then, because Actions do not follow repo redirects.
🤖 Generated with Claude Code