Repository navigation
fix: adopt cli-core 0.663.0 review follow-ups - #184
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
cli-core's factsOf is now async and takes a "written to" lookup. rules apply, messages delete --rules and the cleanup pass store.mail.writtenTo, so a sender the owner answered before the run's window still counts as a correspondent and no envelope rule or Trash offer catches it. Bumps @wirecat/cli-base to 0.100.0, which the next cli-core needs. The cli-core version bump follows its release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…he rules messages delete --rules built its own "wrote to" set from this account's Sent mail, while the rules read store.mail.writtenTo across every account. The cleanup's "replied" reason now asks the same lookup for the envelopes' senders, so the two checks agree and a sender the owner answered from another account is kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pins @wirecat/cli-core 0.663.0 from npm, which carries the async factsOf and the writtenTo lookup. runs list now pages by the configured defaults.limit, so its generated page drops the fixed defaults. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
leemour
force-pushed
the
fix/review-followups
branch
from
November 14, 2026 07:46
ab078b7 to
9868238
Compare
leemour
marked this pull request as ready for review
November 14, 2026 07:46
leemour
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts cli-core #2953 (review follow-ups), released as cli-core 0.663.0.
Why. cli-core's
factsOfis now async and takes a "written to" lookup that reads the owner's stored outgoing mail. mail-cli's rules judged "the owner wrote to this sender" only from the run's window, and the cleanup's "replied" reason kept its own one-account set, so the two could disagree.What.
rules apply,messages delete --rulesand the cleanup passstore.mail.writtenTotofactsOf.@wirecat/cli-core0.663.0 and@wirecat/cli-base0.100.0.docs/commands.mdregenerated (runs listpages bydefaults.limit).Testing. Two new tests, each failing before its change: a reply written before the
rules applywindow, and a reply stored under another account formessages delete --rules. Locally: typecheck, lint,docs:check, 377 tests on one worker.🤖 Generated with Claude Code