Skip to content

fix(stub): put getByDirname on XoopsModule (correct core API) #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mambax7 merged 1 commit into from
Jul 3, 2026
Merged

fix(stub): put getByDirname on XoopsModule (correct core API) #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions stubs/xoops.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,8 @@ namespace {
public function getInfo(string $name = ''): mixed {}

public function dirname(): string {}

public static function getByDirname(string $dirname): ?XoopsModule {}

@gemini-code-assist gemini-code-assist Bot Jul 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In XOOPS core, XoopsModule::getByDirname() (which delegates to XoopsModuleHandler::getByDirname()) returns false on failure rather than null.\n\nUsing ?XoopsModule (which resolves to XoopsModule|null) will cause PHPStan to reject strict comparisons against false (e.g., $module === false), potentially forcing developers to use $module === null which would fail at runtime.\n\nTo prevent this type-safety mismatch, the return type should be declared as XoopsModule|false.

        public static function getByDirname(string $dirname): XoopsModule|false {}

}

class XoopsUser extends XoopsObject
Expand All @@ -171,11 +173,6 @@ namespace {
public function getGroups(): array {}
}

class XoopsModules
{
public static function getByDirname(string $dirname): mixed {}
}

class XoopsPreloadItem
{
public function __construct() {}
Expand Down
Loading