Repository navigation
Observe the missing-review error on the empty-store path - #301
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main's first two CI attempts after PR #300 passed the offline snapshot journey and failed the existing negative saved-review case. In both failures the captured UI showed a blank Review ID field and disabled Reopen button. The empty store already displays the direct-ID field, so that case now submits through it without the extra checkbox action that clears the field during its rerun. The exact browser event ordering on hosted CI is unconfirmed.
The negative case waits for the actual missing-record error and verifies no successful reopen or saved file. The positive continuation cases still exercise the mode toggle. A failure now preserves the browser trace and server log. This changes tests only.
Independent engineering review, focused missing-record AppTest, Ruff and diff checks passed. Both red attempts are recorded on the exact merged source. Main run and attempts