Skip to content

Observe the missing-review error on the empty-store path - #301

Merged
YuzeJ21 merged 1 commit into
mainfrom
codex/observe-missing-review-error
Nov 19, 2026
Merged

YuzeJ21 merged 1 commit into
mainfrom
codex/observe-missing-review-error

Conversation

@YuzeJ21

@YuzeJ21 YuzeJ21 commented Nov 19, 2026

Copy link
Copy Markdown
Owner

Summary

Main's first two CI attempts after PR #300 passed the offline snapshot journey and failed the existing negative saved-review case. In both failures the captured UI showed a blank Review ID field and disabled Reopen button. The empty store already displays the direct-ID field, so that case now submits through it without the extra checkbox action that clears the field during its rerun. The exact browser event ordering on hosted CI is unconfirmed.

The negative case waits for the actual missing-record error and verifies no successful reopen or saved file. The positive continuation cases still exercise the mode toggle. A failure now preserves the browser trace and server log. This changes tests only.

Independent engineering review, focused missing-record AppTest, Ruff and diff checks passed. Both red attempts are recorded on the exact merged source. Main run and attempts

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T21:09:49.924814Z 654262f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@YuzeJ21
YuzeJ21 merged commit d0ded6d into main Nov 19, 2026
11 checks passed
@YuzeJ21
YuzeJ21 deleted the codex/observe-missing-review-error branch November 19, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant