Skip to content

fix(build): replace required Git LFS archive with automatic generation - #13

Merged
edelauna merged 2 commits into
mainfrom
issue/1
Oct 27, 2026
Merged

edelauna merged 2 commits into
mainfrom
issue/1

Conversation

@edelauna

@edelauna edelauna commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #1

Problem

jetbrains_plugin/platform.zip was tracked with Git LFS. The LFS server does not host the object, so a fresh clone fails at git lfs pull with a 404. scripts/setup.sh ran the same pull, so setup failed at that step and the plugin could not build.

Change

  • Remove platform.zip from git and drop the LFS filter from .gitattributes. Ignore the generated archive in jetbrains_plugin/.gitignore.
  • Remove the Git LFS requirement, setup, and pull steps from scripts/setup.sh.
  • In prepareSandbox, depend on the existing genPlatform task when the archive is missing, invalid, or a stale LFS pointer. The build downloads the VS Code distributions pinned by vscodeVersion and generates the archive. genPlatform fails with a clear message when it cannot produce a valid archive.
  • Remove lfs: true from the release workflow checkout.
  • Run the PR workflow also when files under scripts/ change.
  • Add a regression test in scripts/test.sh that checks LFS decoupling. Fix failure counting under set -e so every test group runs and the report totals are correct.
  • Update README.md, BUILD.md, and CHANGELOG.md. Archive generation needs network access to update.code.visualstudio.com.

Validation

  • Local release build with a missing archive and with a stale LFS pointer: prepareSandbox generated the archive and succeeded. Downloads used the local cache of the upstream distributions.
  • New LFS decoupling regression test: passed.
  • Shell syntax checks: passed.
  • Full scripts/test.sh suite: completed with 3 failures. Missing Node.js caused the environment test and build dry-run failures. The required build files check caused the third failure.
  • Fresh-network archive downloads and a Windows checkout: not tested locally.
  • PR CI: the Linux job (connector tests, build, 2026.3 compatibility gates) passed. The Windows job (terminal tests, PowerShell 5.1 smoke) was in progress at the time of this update.

@edelauna
edelauna merged commit e5bd9d6 into main Oct 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] git lfs pull fails during setup phase

1 participant