Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1
Problem
jetbrains_plugin/platform.zipwas tracked with Git LFS. The LFS server does not host the object, so a fresh clone fails atgit lfs pullwith a 404.scripts/setup.shran the same pull, so setup failed at that step and the plugin could not build.Change
platform.zipfrom git and drop the LFS filter from.gitattributes. Ignore the generated archive injetbrains_plugin/.gitignore.scripts/setup.sh.prepareSandbox, depend on the existinggenPlatformtask when the archive is missing, invalid, or a stale LFS pointer. The build downloads the VS Code distributions pinned byvscodeVersionand generates the archive.genPlatformfails with a clear message when it cannot produce a valid archive.lfs: truefrom the release workflow checkout.scripts/change.scripts/test.shthat checks LFS decoupling. Fix failure counting underset -eso every test group runs and the report totals are correct.README.md,BUILD.md, andCHANGELOG.md. Archive generation needs network access toupdate.code.visualstudio.com.Validation
prepareSandboxgenerated the archive and succeeded. Downloads used the local cache of the upstream distributions.scripts/test.shsuite: completed with 3 failures. Missing Node.js caused the environment test and build dry-run failures. The required build files check caused the third failure.