[easonLiangWorldedtech]

Wires the external abort signal and per-request timeout into the completePrompt (non-streaming) and createMessage (streaming) paths of the Unbound, Vercel AI Gateway, and Zoo Gateway providers. Stacks on the shared-util and opencode-go units of this split (resolveModelWithAbort in utils/abort-signal.ts).

Each provider:

• createMessage: bridges metadata?.abortSignal (Bedrock pattern: pre-aborted guard, { once: true } listener, detached on completion so a task-scoped signal does not accumulate listeners) into a per-request AbortController; model resolution runs inside the shared resolveModelWithAbort cancellation scope (pre-aborted fast-fail before any catalog/SDK work, mid-resolution race). Aborted requests (pre-aborted, mid-resolution, mid-stream) normalize to the provider AbortError; non-abort failures propagate or wrap unchanged.
• completePrompt: forwards abortSignal/ timeoutMs to the OpenAI SDK (timeoutMs <= 0 omits the SDK timeout option, since the SDK treats timeout: 0 as an immediate abort); aborted completions and APIConnectionTimeoutError normalize to the provider AbortError (series standard).

Zoo Gateway places the entry fast-fail before ensureAuthenticated() so a pre-aborted task surfaces the AbortError instead of an auth failure.

Tests:

• Ported the reference abort/timeout completePrompt pass-through tests (signal, timeoutMs incl. 0, and no-options backward compatibility) for all three providers, plus normalization/identity tests for aborted and timed-out completions.
• createMessage bridging tests per provider: pre-aborted signal -> rejects with the standardized AbortError before any request work (catalog and SDK both uncalled; unbound additionally asserts the SDK-level rejection identity since its error wrapper preserves main's behavior); abort mid-resolution -> settles on the standardized AbortError before the lookup is released, no late request; detach tests use the reference-identity pattern (the resolution race registers its own "abort" listener, so the bridge is the last registration).

Series and unit

Unit 3/3 of the #1295 split (content source: 62f596c5d); stacks on the shared-util and opencode-go units. Three sibling OpenAI-SDK gateway providers with an identical abort-wiring shape are kept as one unit to avoid tripling the review surface for mechanically identical changes (a+d soft-cap rationale per the split budget; the mutation gate is measured on the unit delta and is green).

Part of the abort-signal series (round 1). Builds on #674, #901, #1008. Addresses #404.

Review response (maintainer review of #1295)

• The model-resolution guard, the rejectOnAbort race, and the abort normalization now live once in the shared util (resolveModelWithAbort, unit 1/3) instead of being inlined per provider; all three providers call it and each spec exercises it end-to-end (pre-aborted -> catalog and SDK both uncalled; mid-resolution -> standardized AbortError before the lookup is released, no late request).
• The createMessage catches use the wider isRequestAborted condition (aborted signal, DOM AbortError, SDK APIUserAbortError, exact "Request was aborted." message; name/message checks require a real Error instance).
• The detach tests assert reference identity on the last "abort" registration, because the resolution race registers its own listener on the same external signal.

Evidence

• vitest: 139/139 passing across the three gateway suites (134 changed executable lines, all covered)
• Local Stryker mutation gate (unit delta vs own base): 185 valid mutants (≤400), 176 killed, 9 directive-ignored (the per-request bridge's unreachable pre-aborted branch per provider, with invariant-citing proofs), 0 Survived / 0 NoCoverage / 0 Timeout

---

Updated this round (2026-10-13)

Merged current upstream main into the branch to clear the dirty state. Conflicts: vercel-ai-gateway.ts/zoo-gateway.ts (imports only — main's model-cache fetcher imports plus this branch's abort-signal utility imports, both kept) and unbound.spec.ts (main's new "model catalog" describe block coexists with this branch's appended abort/cancellation suites — both kept).

Verification at this head: 535/535 green across the touched provider specs (unbound, vercel-ai-gateway, zoo-gateway, opencode-go); tsc --noEmit → 0 errors; per-file ESLint (--max-warnings=0) clean; prettier --check clean on touched files.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Zoo-Code-Org/Zoo-Code
• Branch: main
• File: .coderabbit.yaml
• Commit: 3f51e9d
• Layers: Repository YAML
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: eca6b72d-e995-41b0-9c01-cfd5cdbefc58

Commits

Reviewing files that changed from the base of the PR and between 76f0dc8 and 17975dd.

Files selected for processing: 4

• src/api/providers/opencode-go.ts
• src/api/providers/unbound.ts
• src/api/providers/vercel-ai-gateway.ts
• src/api/providers/zoo-gateway.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

Recent review details

Context from checks skipped due to timeout: 16

• GitHub Check: CodeRabbit
• GitHub Check: platform-unit-test (windows-latest)
• GitHub Check: mutation-diff
• GitHub Check: extension-host-visual
• GitHub Check: invisible-chars
• GitHub Check: platform-unit-test (ubuntu-latest)
• GitHub Check: webview-visual
• GitHub Check: Build test VSIX
• GitHub Check: check-translations
• GitHub Check: compile
• GitHub Check: knip
• GitHub Check: theme-fixtures
• GitHub Check: dependency-review
• GitHub Check: e2e-mock
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Zoo Code / resolve PRs to reconcile

Additional context used

Path-based instructions: 4

Treat model, provider, MCP, path, command, and tool data as untrusted.

CodeRabbit configuration file

Files:

• src/api/providers/unbound.ts
• src/api/providers/vercel-ai-gateway.ts
• src/api/providers/zoo-gateway.ts
• src/api/providers/opencode-go.ts

Check strict typing and exhaustive behavior across normal, boundary, error, cancellation, retry, and compatibility paths.

CodeRabbit configuration file

Files:

• src/api/providers/unbound.ts
• src/api/providers/vercel-ai-gateway.ts
• src/api/providers/zoo-gateway.ts
• src/api/providers/opencode-go.ts

Verify extension/webview contracts, cancellation and error propagation, VS Code lifecycle correctness, and behavior under retries and partial failure.

CodeRabbit configuration file

Files:

• src/api/providers/unbound.ts
• src/api/providers/vercel-ai-gateway.ts
• src/api/providers/zoo-gateway.ts
• src/api/providers/opencode-go.ts

Act as an adversarial second-opinion reviewer.

CodeRabbit configuration file

Files:

• src/api/providers/unbound.ts
• src/api/providers/vercel-ai-gateway.ts
• src/api/providers/zoo-gateway.ts
• src/api/providers/opencode-go.ts

Learnings: 1

Common learnings

Learnt from: easonLiangWorldedtech
Repo: Zoo-Code-Org/Zoo-Code PR: 1653
File: src/api/providers/unbound.ts:270-280
Timestamp: 2026-10-04T19:26:43.827Z
Learning: In src/api/providers/zoo-gateway.ts, ZooGatewayHandler.createMessage and ZooGatewayHandler.completePrompt must reject pre-aborted requests with the standardized provider AbortError before ensureAuthenticated runs. A resolveModelWithAbort check after authentication is not equivalent, because an authentication failure must not override cancellation. Regression tests should include a pre-aborted signal with an unauthenticated session.

Additional comments: 4

src/api/providers/opencode-go.ts: 1

44-51: LGTM!

Also applies to: 240-255, 258-279, 284-305, 309-344, 347-398

src/api/providers/unbound.ts: 1

32-39: LGTM!

Also applies to: 194-200, 203-261, 265-273

src/api/providers/vercel-ai-gateway.ts: 1

28-35: LGTM!

Also applies to: 123-129, 131-188, 192-200

src/api/providers/zoo-gateway.ts: 1

31-38: LGTM!

Also applies to: 258-264, 269-269, 329-330, 334-340, 344-351

📝 Summary

Summary by CodeRabbit

• Bug Fixes
  • Canceled requests across OpenCode Go, Unbound, Vercel AI Gateway, and Zoo Gateway now return consistent abort errors, including when canceled before a request, during model lookup, or while streaming.
  • Prompt completions forward cancellation signals and apply positive timeout settings; zero timeouts are omitted. Timeout errors are reported consistently, while unrelated errors retain their existing behavior.
  • Streaming requests remove cancellation listeners when finished, helping prevent stale listeners after completion. Anthropic prompt completions also apply the configured maximum-token override.

Four provider handlers now resolve models with abort handling, forward cancellation signals to streaming and completion requests, and normalize recognized abort and timeout errors. Tests cover cancellation timing, listener cleanup, completion options, and stream-frame handling.

Changes: Provider cancellation and timeout handling

Layer / File(s)	Summary
Model resolution and streaming cancellation src/api/providers/opencode-go.ts, src/api/providers/unbound.ts, src/api/providers/vercel-ai-gateway.ts, src/api/providers/zoo-gateway.ts, src/api/providers/__tests__/*.spec.ts	Handlers resolve models with abort handling and bridge caller signals to streaming requests. They normalize recognized cancellations and remove listeners. Tests cover lookup and stream cancellation, listener cleanup, and stream-frame behavior.
Completion cancellation and timeout options src/api/providers/opencode-go.ts, src/api/providers/unbound.ts, src/api/providers/vercel-ai-gateway.ts, src/api/providers/zoo-gateway.ts, src/api/providers/__tests__/*.spec.ts	Completion requests forward abort signals and positive timeouts. They omit nonpositive timeouts and normalize recognized abort and timeout errors. Tests cover request options, cancellation, and calls without options.

Priority: Normal

Estimated code review effort: 4 (Complex) | ~55 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant Caller
  participant ProviderHandler
  participant ModelResolver
  participant ProviderSDK
  ProviderHandler->>ModelResolver: Resolve model with caller signal
  ModelResolver-->>ProviderHandler: Return model or abort error
  ProviderHandler->>ProviderSDK: Start request with bridged signal
  Caller->>ProviderSDK: Abort request signal
  ProviderSDK-->>ProviderHandler: Return stream or abort error

Loading

Possibly related issues

• Zoo-Code-Org/Zoo-Code#2202: Provider calls now settle when cancellation occurs during model resolution. This issue describes the separate behavior of aborting shared discovery after all waiters cancel.

Possibly related PRs

• Zoo-Code-Org/Zoo-Code#1652: This PR adds the OpenCode Go request-path changes and listener-cleanup tests also present in this pull request.
• Zoo-Code-Org/Zoo-Code#1293: This PR adds abort-bridge and timeout helpers that this pull request reports using across providers.
• Zoo-Code-Org/Zoo-Code#1538: This PR adds cancellation during model discovery for Requesty, matching a request-cancellation behavior also covered here.

Merge Risk: Minimal · up to 17975

No actionable blocker is established; the change is mergeable after normal checks.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 07aeb

The reviewed paths retain existing authentication and request permissions while honoring cancellation. Remaining uncertainty concerns how quickly in-flight work stops when a consumer exits before a response arrives.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The added control affects requests subscribing to the caller's signal. Controllers and completion options are invocation-local rather than stored as handler-wide cancellation state. Reusing a signal can intentionally cancel multiple subscribing requests, but the inspected changes do not grant new credential or tool authority.

Trust Boundaries and Controls

• observed — Caller cancellation becomes transport-control state: the shared helper checks the signal before initiating lookup, and provider request paths forward a caller signal or request-local controller signal. These controls do not alter credential selection or convert cancellation into permission to perform protected work.

Resilience and Maintainability Implications

• inferred — Immediate resource release from iterator.return() alone while Zoo's initial SDK await is pending remains unverified. The pending-await structure predates this PR, while the PR adds an explicit external-signal cancellation route. This is a bounded cleanup uncertainty, not evidence of newly expanded authority or a verified security regression.

Pre-merge checks: 6 · 2

Failed checks: 2 warnings

Check name	Status	Explanation	Resolution
Regression Evidence		The prior regression finding remains. The changed providers omit SDK timeout unless hasUsableTimeout(timeoutMs) returns true (Unbound: unbound.ts:292; Vercel AI Gateway: vercel-ai-gateway.ts:227…	Add focused completePrompt tests with a negative timeoutMs and assert that the SDK options omit timeout for Unbound, Vercel AI Gateway, Zoo Gateway, and OpenCode Go's Anthropic, Responses, and Chat Completions paths. Where the test su…
Lifecycle Resource Cleanup		The changed Zoo Gateway cancellation path can leave catalog work running after cancellation and duplicate that work on restart. zoo-gateway.ts now wraps this.fetchModel() in `resolveModelWithAbort…	Thread the caller signal through RouterProvider.fetchModel, getModels/refreshModels, ZooGatewayHandler.fetchModels, and getZooGatewayModels into the Axios request. Preserve single-flight behavior for non-auth-scoped providers. For…

Passed checks: 6 passed

Check name	Status	Explanation
Title check		The title clearly summarizes the main change: abort-signal support for the Unbound, Vercel AI Gateway, and Zoo Gateway providers.
Description check		The description explains the implementation, identifies issue #404, and reports test procedures and results. It does not include the template’s completed pre-submission checklist or documentation-impa…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Security Boundaries		The changed provider paths add abort-signal and timeout handling. They do not add secret or PII disclosure, execution of unvalidated input, or a bypass of approval or allowlist controls. The request c…
Persistence Integrity		The reviewed diff changes four provider implementations and their tests. The implementation changes add abort-signal and timeout handling to model lookup and API requests. No changed persistence path,…

Full details: Description check

Explanation

The description explains the implementation, identifies issue #404, and reports test procedures and results. It does not include the template’s completed pre-submission checklist or documentation-impact section, but the main required information is present.

Full details: Security Boundaries

Explanation

The changed provider paths add abort-signal and timeout handling. They do not add secret or PII disclosure, execution of unvalidated input, or a bypass of approval or allowlist controls. The request changes forward signals and usable timeout values to SDK calls. Existing Zoo Gateway authentication checks remain in place for non-aborted requests.

Full details: Persistence Integrity

Explanation

The reviewed diff changes four provider implementations and their tests. The implementation changes add abort-signal and timeout handling to model lookup and API requests. No changed persistence path, write operation, rollback behavior, or persisted default propagation appears in the diff, so the check’s failure conditions are not met.

Full details: Regression Evidence

Explanation

The prior regression finding remains. The changed providers omit SDK timeout unless hasUsableTimeout(timeoutMs) returns true (Unbound: unbound.ts:292; Vercel AI Gateway: vercel-ai-gateway.ts:227; Zoo Gateway: zoo-gateway.ts:374; OpenCode Go: opencode-go.ts:870, 920, 998). The focused completePrompt tests cover positive values and timeoutMs: 0, but none supplies a negative timeoutMs in these provider specs (unbound.spec.ts:406, 426; vercel-ai-gateway.spec.ts:869, 891; zoo-gateway.spec.ts:570, 586; opencode-go.spec.ts:1182, 1378, 2472 are the zero-value cases). The shared helper test covers -5, but it does not verify that each provider omits the SDK timeout. A provider could therefore forward a negative timeout without failing the provider-level tests.

Resolution

Add focused completePrompt tests with a negative timeoutMs and assert that the SDK options omit timeout for Unbound, Vercel AI Gateway, Zoo Gateway, and OpenCode Go's Anthropic, Responses, and Chat Completions paths. Where the test supplies an abort signal, also assert that the signal remains present in the SDK options.

Full details: Lifecycle Resource Cleanup

Explanation

The changed Zoo Gateway cancellation path can leave catalog work running after cancellation and duplicate that work on restart. zoo-gateway.ts now wraps this.fetchModel() in resolveModelWithAbort; rejectOnAbort settles the caller but explicitly leaves the underlying promise running (utils/abort-signal.ts:157-162). RouterProvider.fetchModel starts getModels and refreshModels without a signal (router-provider.ts:76-108). Zoo is auth-scoped, so both cache paths bypass single-flight and call fetchModelsFromProvider without a signal (modelCache.ts:210-236, 421-439). getZooGatewayModels then makes an Axios request with only a 15-second timeout (fetchers/zoo-gateway.ts:36-40). If cancellation occurs during lookup and a new handler starts, its separate modelFetchPromise can launch another catalog request while the first remains active. The new tests release their mocked lookup after asserting cancellation; they do not verify cancellation of the Axios request or prevent overlap.

Resolution

Thread the caller signal through RouterProvider.fetchModel, getModels/refreshModels, ZooGatewayHandler.fetchModels, and getZooGatewayModels into the Axios request. Preserve single-flight behavior for non-auth-scoped providers. For auth-scoped Zoo requests, cancel the catalog request when its last waiter aborts. Add a regression test that aborts a pending Zoo catalog lookup, starts a new handler, and verifies that the canceled lookup is released without overlapping the new request.

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/api/providers/opencode-go.ts

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

src/api/providers/unbound.ts

ESLint skipped: the matched ESLint configuration already failed (missing-dependency).

src/api/providers/vercel-ai-gateway.ts

ESLint skipped: the matched ESLint configuration already failed (missing-dependency).

• 1 others

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Review status

Thanks for contributing. This comment tracks the review sequence and the next action.

Current step: Awaiting fresh human maintainer or CODEOWNER approval.

Automated review is complete for the latest commit but does not replace human approval.

Review-state labels are managed by this workflow; do not edit them manually. community-approved is managed the same way — do not add or remove it manually. It signals a fresh community code approval for the current head as an advisory priority only; maintainer review is still required.

[codecov]

Codecov Report

❌ Patch coverage is 96.19565% with 7 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/api/providers/opencode-go.ts	93.75%	0 Missing and 5 partials ⚠️
src/api/providers/vercel-ai-gateway.ts	95.12%	0 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

[easonLiangWorldedtech]

@coderabbitai full review

[coderabbitai]

⚠️ Action not completed

Review rate limited.

---

Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 8 minutes.

[easonLiangWorldedtech]

@coderabbitai full review

[coderabbitai]

⚠️ Action not completed

Review rate limited.

---

Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 3 minutes.

[easonLiangWorldedtech]

@coderabbitai full review

[easonLiangWorldedtech]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[easonLiangWorldedtech]

All four review threads addressed

zoo-gateway.ts, unbound.ts, vercel-ai-gateway.ts and opencode-go.ts now use the shared bridgeExternalAbortSignal from utils/abort-signal.ts instead of four copies of the inline controller/listener/pre-abort block:

• pre-aborted caller signals abort the request-local signal immediately;
• the listener is { once: true } and is detached via the helper's dispose() in every format branch's finally (replacing the repeated removeEventListener calls);
• a never-aborting fallback signal is kept when the caller supplies no external signal, preserving the previous always-signal behaviour for the SDK calls.

Local: unbound + zoo-gateway + vercel-ai-gateway + opencode-go specs 582 passed.

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.