Repository navigation
Conversation
|
@Krshivam25 is attempting to deploy a commit to the Aave Team on Vercel. A member of the Team first needs to authorize it. |
…ader accessible - Render the "Recently used & Popular" token chips as buttons so they can be focused with Tab and activated with Enter/Space, with a focus-visible style matching hover. - Give the icon-only swap controls accessible names: switch input and output assets, the disabled swap-direction arrow, and clear amount. - Give the input, output and limit-price fields distinct accessible names instead of a shared "amount input". - Update the Cypress switch-tool selector to the new input name. Closes aave#3100
shivam-V8
force-pushed
the
fix/3100-swap-controls-a11y
branch
from
October 24, 2026 08:35
96d9276 to
83c5540
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3100
General Changes
ButtonBaseinstead of a click-onlyBox, so keyboard users can Tab to them and select with Enter/Space. They get a focus-visible style matching hover.amount input: they are now Input amount and Output amount, and the limit-order price field is Limit price.input[aria-label="Input amount"].pnpm i18n. Clear amount is the same string fix: add accessible names to icon-only buttons #3133 uses forAssetInput, so both share one catalog entry.No visual changes, apart from the new focus state on the token chips.
Developer Notes
IconButtonguard lists exactly these five swap buttons inKNOWN_UNLABELLED(LimitOrderInputs.tsx:145,184,MarketOrderInputs.tsx:113,145,SwapAssetInput.tsx:360), with a note that they're left for bug: swap token controls are not fully keyboard and screen-reader accessible #3100. Whichever PR merges second needs to empty that list, because all five are now labelled.pnpm test:cishows 4 failing suites (3 failing tests:RotationProvider,getMaxAmountAvailableToBorrow,ghoUtilities,marketsAndNetworkConfig). The same suites fail on a cleanmain, so this branch adds no new failures.tsc --noEmit, ESLint and Prettier pass.Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files