Repository navigation
fix(reporting-storage): require the adcp release that contains the split - #1577
Conversation
adcp 9.0.0b4 predates the storage split and lacks the modules this package imports (adcp.reporting.ledger._record_rows, adcp.reporting.production.store, adcp.reporting.outbox.durable), so installing it with the b4 beta fails at import. Require adcp 9.0.0. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
![aao-secretariat[bot]](https://avatars.githubusercontent.com/u/221690821?s=60&v=4){kind=small}
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean dependency-floor fix with no findings.
This PR bumps the adcp dependency floor from adcp>=9.0.0b4,<10 to adcp>=9.0.0,<10 in two files, in lockstep:
packages/adcp-reporting-storage/pyproject.toml:35packages/adcp-reporting-storage/README.md:57
The change is correct: 9.0.0b4 sorts below 9.0.0 under PEP 440, so the old floor could resolve to the pre-split beta that lacks the private adcp.reporting helpers this package imports (import-time failure). 9.0.0 is now released and is a valid publishable floor. Scope is confined to the storage package; the adcp package itself is untouched.
Decision trace: no critical/high/medium findings (rows 1, 4–8 N/A); gated_paths is false (row 2 N/A); high_risk is false (rows 3, 5 N/A); no prior decision (row 6 N/A); no no-auto-approve team match (row 7 N/A). Falls through to row 9 → approve. (review_decision: REVIEW_REQUIRED only matters for the gated-paths gate, which does not apply here.)
adcp-reporting-storagepinnedadcp>=9.0.0b4,<10, but the published 9.0.0b4 predates the split. It lacksadcp.reporting.ledger._record_rows,adcp.reporting.production.storeandadcp.reporting.outbox.durable. A pre-merge review of #1557 reproduced the failure:pip install adcp==9.0.0b4plus the storage wheel installs, thenfrom adcp_reporting_storage import PgReportingLedgerStoreraisesModuleNotFoundError.Now that 9.0.0 is released, the floor becomes
adcp>=9.0.0,<10, and the package README matches. This touches onlypackages/adcp-reporting-storage/, so it updates the storage release PR (#1571) and notadcp.Merge this before #1571. #1571 also needs the PyPI pending Trusted Publisher for
adcp-reporting-storage, described indocs/releasing.md.tests/test_release_configuration.pyandtests/test_reporting_storage_boundary.py: 9 passed.🤖 Generated with Claude Code